From 917816f6725cae8a4e6bf03f104dea00d79f822c Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Sun, 6 Nov 2022 12:56:49 +0100 Subject: [PATCH] refactor(core): remove duplicate createRenderer call (#47981) Fixes that we were calling `createRenderer` even though we had one already. This likely wasn't a performance issue since the renderer factory caches the renderer, but it's still better to reuse it to avoid confusion in the future. Fixes #47980. PR Close #47981 --- packages/core/src/render3/component_ref.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/core/src/render3/component_ref.ts b/packages/core/src/render3/component_ref.ts index 28644494c7b..df9ef258101 100644 --- a/packages/core/src/render3/component_ref.ts +++ b/packages/core/src/render3/component_ref.ts @@ -169,9 +169,7 @@ export class ComponentFactory extends AbstractComponentFactory { const elementName = this.componentDef.selectors[0][0] as string || 'div'; const hostRNode = rootSelectorOrNode ? locateHostElement(hostRenderer, rootSelectorOrNode, this.componentDef.encapsulation) : - createElementNode( - rendererFactory.createRenderer(null, this.componentDef), elementName, - getNamespace(elementName)); + createElementNode(hostRenderer, elementName, getNamespace(elementName)); const rootFlags = this.componentDef.onPush ? LViewFlags.Dirty | LViewFlags.IsRoot : LViewFlags.CheckAlways | LViewFlags.IsRoot;