From 909e543f7ebfaaa917d894f20ea08a352dbecd64 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 26 May 2025 17:06:14 +0000 Subject: [PATCH] build: do not run ssr-benchmarks when using `//...` (#61566) These are also excluded on CI, and shouldn't run locally either as they are "manual debug" targets. PR Close #61566 --- modules/ssr-benchmarks/BUILD.bazel | 9 ++++----- modules/ssr-benchmarks/package.json | 6 ++---- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/modules/ssr-benchmarks/BUILD.bazel b/modules/ssr-benchmarks/BUILD.bazel index 0791e235518..a0a9624ec1b 100644 --- a/modules/ssr-benchmarks/BUILD.bazel +++ b/modules/ssr-benchmarks/BUILD.bazel @@ -7,6 +7,7 @@ ng_integration_test( "yarn ng build", "node ./dist/ssr-benchmarks/server/server.mjs", ], + tags = ["manual"], ) ## This target is intended to run the benchmark in a browser @@ -17,12 +18,11 @@ ng_integration_test( commands = [ "yarn install --cache-folder ./.yarn_local_cache", - # The patch only applies for the browser target (to remove the DOM Emulation polyfills and browser incompatible code) - "yarn patch", # "NG_BUILD_MANGLE=0 yarn ng build --configuration production,browser", "yarn http-server ./dist", ], + tags = ["manual"], ) # This target is mostly intended for investigating via the devTools using the flamechart @@ -30,14 +30,12 @@ ng_integration_test( name = "run_browser_emulated_dom", commands = [ "yarn install --cache-folder ./.yarn_local_cache", - # We keep the emulated dom in this target - # But still need to drop the node import which doesn't work in browsers. - "git apply patches/@angular-devkit+build-angular++@angular+build+19.0.0-next.6+require.patch", # We keep the symbols with the NG_BUILD_MANGLE flag "NG_BUILD_MANGLE=0 yarn ng build", "yarn http-server ./dist", ], + tags = ["manual"], ) # This is a target to investigate with deopt explorer (https://github.com/microsoft/deoptexplorer-vscode) @@ -58,4 +56,5 @@ ng_integration_test( --detailed-line-info \ ./dist/ssr-benchmarks/server/server.mjs narrowRun", ], + tags = ["manual"], ) diff --git a/modules/ssr-benchmarks/package.json b/modules/ssr-benchmarks/package.json index d71452098ea..ab80fb51e97 100644 --- a/modules/ssr-benchmarks/package.json +++ b/modules/ssr-benchmarks/package.json @@ -2,13 +2,12 @@ "name": "ssr-benchmark", "version": "0.0.0", "scripts": { - "patch": "yarn patch-package", "ng": "ng", "http-server": "http-server" }, "license": "MIT", "dependencies": { - "@angular-devkit/build-angular": "file:../../node_modules/@angular-devkit/build-angular", + "@angular-devkit/build-angular": "20.0.0-rc.1", "@angular/cli": "file:../../node_modules/@angular/cli", "@angular/common": "file:../../dist/packages-dist/common", "@angular/compiler": "file:../../dist/packages-dist/compiler", @@ -20,7 +19,6 @@ "@angular/ssr": "file:../../node_modules/@angular/ssr", "rxjs": "file:../../node_modules/rxjs", "typescript": "file:../../node_modules/typescript", - "http-server": "file:../../node_modules/http-server", - "patch-package": "file:../../node_modules/patch-package" + "http-server": "file:../../node_modules/http-server" } }