From 8b0340626e67697c41d41f29ebd3ed771271dc7b Mon Sep 17 00:00:00 2001 From: Dylan Hunn Date: Mon, 28 Aug 2023 21:29:54 -0700 Subject: [PATCH] refactor(compiler): Enable some additional passing tests for template pipeline (#51544) A couple more tests pertaining to animations became passing at some point recently, as well as a few form other assorted areas. PR Close #51544 --- .../lifecycle_hooks/TEST_CASES.json | 5 ++--- .../r3_view_compiler/animations/TEST_CASES.json | 8 +++----- .../property_bindings/TEST_CASES.json | 3 +-- .../test_cases/r3_view_compiler_listener/TEST_CASES.json | 3 +-- ...licit_receiver_keyed_write_inside_template_template.js | 4 ++-- 5 files changed, 9 insertions(+), 14 deletions(-) diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/lifecycle_hooks/TEST_CASES.json b/packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/lifecycle_hooks/TEST_CASES.json index 3db59bf27b2..fd22e36cf03 100644 --- a/packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/lifecycle_hooks/TEST_CASES.json +++ b/packages/compiler-cli/test/compliance/test_cases/r3_compiler_compliance/components_and_directives/lifecycle_hooks/TEST_CASES.json @@ -69,8 +69,7 @@ } ] } - ], - "skipForTemplatePipeline": true + ] } ] -} +} \ No newline at end of file diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/animations/TEST_CASES.json b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/animations/TEST_CASES.json index 3bafb470888..c8ee5d619c0 100644 --- a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/animations/TEST_CASES.json +++ b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler/animations/TEST_CASES.json @@ -16,8 +16,7 @@ ], "failureMessage": "Incorrect initialization attributes" } - ], - "skipForTemplatePipeline": true + ] }, { "description": "should dedup multiple [@event] listeners", @@ -34,8 +33,7 @@ ], "failureMessage": "Incorrect initialization attributes" } - ], - "skipForTemplatePipeline": true + ] } ] -} +} \ No newline at end of file diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings/property_bindings/TEST_CASES.json b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings/property_bindings/TEST_CASES.json index 0c9f5b7b59e..72965408b64 100644 --- a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings/property_bindings/TEST_CASES.json +++ b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_bindings/property_bindings/TEST_CASES.json @@ -126,8 +126,7 @@ "chain_synthetic_bindings.js" ] } - ], - "skipForTemplatePipeline": true + ] }, { "description": "should chain multiple property bindings on an ng-template", diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/TEST_CASES.json b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/TEST_CASES.json index f9077d03bb8..27b6fc3d9ab 100644 --- a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/TEST_CASES.json +++ b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/TEST_CASES.json @@ -281,8 +281,7 @@ ], "failureMessage": "Incorrect template" } - ], - "skipForTemplatePipeline": true + ] }, { "description": "should reference correct context in listener inside embedded view", diff --git a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/implicit_receiver_keyed_write_inside_template_template.js b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/implicit_receiver_keyed_write_inside_template_template.js index 3a7d419b4e1..1df7c958eb4 100644 --- a/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/implicit_receiver_keyed_write_inside_template_template.js +++ b/packages/compiler-cli/test/compliance/test_cases/r3_view_compiler_listener/implicit_receiver_keyed_write_inside_template_template.js @@ -1,9 +1,9 @@ function MyComponent_ng_template_0_Template(rf, $ctx$) { if (rf & 1) { - const _r3 = $i0$.ɵɵgetCurrentView(); + const $_r3$ = $i0$.ɵɵgetCurrentView(); $i0$.ɵɵelementStart(0, "button", 1); $i0$.ɵɵlistener("click", function MyComponent_ng_template_0_Template_button_click_0_listener() { - $i0$.ɵɵrestoreView(_r3); + $i0$.ɵɵrestoreView($_r3$); const $ctx_2$ = $i0$.ɵɵnextContext(); return $i0$.ɵɵresetView(($ctx_2$["mes" + "sage"] = "hello")); });