From 8b02d11fbbc8fdc2adf152b359255c38f54b60bb Mon Sep 17 00:00:00 2001 From: Alex Rickabaugh Date: Thu, 5 Dec 2024 13:02:01 -0800 Subject: [PATCH] refactor(compiler): remove circular dep in the output ast (#59083) Use `import type` to break a phantom circular import in the output AST in the compiler. PR Close #59083 --- goldens/circular-deps/packages.json | 9 --------- packages/compiler/src/output/output_ast.ts | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json index bf2e982e71a..d3bfc00d64a 100644 --- a/goldens/circular-deps/packages.json +++ b/goldens/circular-deps/packages.json @@ -1,13 +1,4 @@ [ - [ - "packages/compiler/src/output/output_ast.ts", - "packages/compiler/src/render3/view/i18n/meta.ts" - ], - [ - "packages/compiler/src/output/output_ast.ts", - "packages/compiler/src/render3/view/i18n/meta.ts", - "packages/compiler/src/render3/view/i18n/util.ts" - ], [ "packages/core/src/change_detection/change_detector_ref.ts", "packages/core/src/render3/view_ref.ts" diff --git a/packages/compiler/src/output/output_ast.ts b/packages/compiler/src/output/output_ast.ts index 3c19e469d2c..d5b1bf3458d 100644 --- a/packages/compiler/src/output/output_ast.ts +++ b/packages/compiler/src/output/output_ast.ts @@ -9,7 +9,7 @@ import {computeMsgId} from '../i18n/digest'; import {Message} from '../i18n/i18n_ast'; import {ParseSourceSpan} from '../parse_util'; -import {I18nMeta} from '../render3/view/i18n/meta'; +import type {I18nMeta} from '../render3/view/i18n/meta'; //// Types export enum TypeModifier {