From 87aaa4933ca074f7d746b704bd3198c6bb991eab Mon Sep 17 00:00:00 2001 From: AleksanderBodurri Date: Thu, 5 Mar 2020 11:13:01 -0500 Subject: [PATCH] fix(devtools): check if node.children is undefined before trying to convert it into an array (ex. node is a text node) --- projects/ng-devtools-backend/src/lib/observer/observer.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/projects/ng-devtools-backend/src/lib/observer/observer.ts b/projects/ng-devtools-backend/src/lib/observer/observer.ts index b9a526fa976..6e873242222 100644 --- a/projects/ng-devtools-backend/src/lib/observer/observer.ts +++ b/projects/ng-devtools-backend/src/lib/observer/observer.ts @@ -172,7 +172,7 @@ export class ComponentTreeObserver { if (component) { componentAccumulator.push(component); } else { - Array.from(node.children).forEach(child => + Array.from(node.children || []).forEach(child => this._getAllNestedComponentsWithinDomNode(child, componentAccumulator) ); } @@ -186,9 +186,10 @@ export class ComponentTreeObserver { directives = ng.getDirectives(node); } catch {} - Array.from(node.children).forEach( + Array.from(node.children || []).forEach( child => (directives = directives.concat(this._getAllNestedDirectivesWithinDomNode(child))) ); + return directives; }