From 83bd63fa7c91cdaa6f8efc31447e66237f348c8c Mon Sep 17 00:00:00 2001 From: arturovt Date: Thu, 9 Jan 2025 00:38:18 +0200 Subject: [PATCH] refactor(common): drop `NullViewportScroller` for client bundles (#59440) In this commit, we replace the `isPlatformBrowser` runtime call with the `ngServerMode` in order to drop the `NullViewportScroller` for client bundles. PR Close #59440 --- packages/common/src/viewport_scroller.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/common/src/viewport_scroller.ts b/packages/common/src/viewport_scroller.ts index 0aec9d69e4c..da4f021aac5 100644 --- a/packages/common/src/viewport_scroller.ts +++ b/packages/common/src/viewport_scroller.ts @@ -6,10 +6,9 @@ * found in the LICENSE file at https://angular.dev/license */ -import {inject, PLATFORM_ID, ɵɵdefineInjectable} from '@angular/core'; +import {inject, ɵɵdefineInjectable} from '@angular/core'; import {DOCUMENT} from './dom_tokens'; -import {isPlatformBrowser} from './platform_id'; /** * Defines a scroll position manager. Implemented by `BrowserViewportScroller`. @@ -24,9 +23,9 @@ export abstract class ViewportScroller { token: ViewportScroller, providedIn: 'root', factory: () => - isPlatformBrowser(inject(PLATFORM_ID)) - ? new BrowserViewportScroller(inject(DOCUMENT), window) - : new NullViewportScroller(), + typeof ngServerMode !== 'undefined' && ngServerMode + ? new NullViewportScroller() + : new BrowserViewportScroller(inject(DOCUMENT), window), }); /**