Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(core): wrap operationsCounter calls with ngDevMode checks

Browse source 
Wrap operationsCounter method calls (recordCreate, recordDestroy, reset)
with ngDevMode guards to ensure they are tree-shaken in production builds.

This aligns with the existing pattern where operationsCounter is only
initialized in development mode, and eliminates unnecessary method call
overhead in production.

The optional chaining (?.) is retained as TypeScript doesn't narrow types
based on ngDevMode checks, but the entire expression will be removed during
production builds.
This commit is contained in:
arturovt 2025-12-08 23:37:28 +02:00 committed by Alex Rickabaugh
parent 8199945637
commit 80dbd74ae8
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/core/src/render3/instructions/control_flow.ts
View file

@ -440,13 +440,13 @@ class LiveCollectionLContainerImpl extends LiveCollection<
new RepeaterContext(this.lContainer, value, index),
{dehydratedView},
);
this.operationsCounter?.recordCreate();
ngDevMode && this.operationsCounter?.recordCreate();
return embeddedLView;
}
override destroy(lView: LView<RepeaterContext<unknown>>): void {
destroyLView(lView[TVIEW], lView);
this.operationsCounter?.recordDestroy();
ngDevMode && this.operationsCounter?.recordDestroy();
}
override updateValue(index: number, value: unknown): void {
this.getLView(index)[CONTEXT].$implicit = value;
@ -454,7 +454,7 @@ class LiveCollectionLContainerImpl extends LiveCollection<
reset(): void {
this.needsIndexUpdate = false;
this.operationsCounter?.reset();
ngDevMode && this.operationsCounter?.reset();
}
updateIndexes(): void {