Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(forms): update minlength/maxlength to inherit abstractValidator

Browse source 
Modified minlength and maxlength validator to inherit abstractValidator

For every validator type different PR will be raised as discussed in #42378.

Closes #42267
This commit is contained in:
iRealNirmal 2021-10-14 09:36:32 +05:30
parent a91fe6db8c
commit 7b31b887f9
2 changed files with 25 additions and 84 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
goldens/public-api/forms/forms.md
View file

@ -454,14 +454,10 @@ export class FormsModule {
}
// @public
export class MaxLengthValidator implements Validator, OnChanges {
// (undocumented)
enabled(): boolean;
export class MaxLengthValidator extends AbstractValidatorDirective implements OnChanges {
maxlength: string | number | null;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
registerOnValidatorChange(fn: () => void): void;
validate(control: AbstractControl): ValidationErrors | null;
// (undocumented)
static ɵdir: i0.ɵɵDirectiveDeclaration<MaxLengthValidator, "[maxlength][formControlName],[maxlength][formControl],[maxlength][ngModel]", never, { "maxlength": "maxlength"; }, {}, never>;
// (undocumented)
@ -479,14 +475,10 @@ export class MaxValidator extends AbstractValidatorDirective implements OnChange
}
// @public
export class MinLengthValidator implements Validator, OnChanges {
// (undocumented)
enabled(): boolean;
export class MinLengthValidator extends AbstractValidatorDirective implements OnChanges {
minlength: string | number | null;
// (undocumented)
ngOnChanges(changes: SimpleChanges): void;
registerOnValidatorChange(fn: () => void): void;
validate(control: AbstractControl): ValidationErrors | null;
// (undocumented)
static ɵdir: i0.ɵɵDirectiveDeclaration<MinLengthValidator, "[minlength][formControlName],[minlength][formControl],[minlength][ngModel]", never, { "minlength": "minlength"; }, {}, never>;
// (undocumented)

97
packages/forms/src/directives/validators.ts
View file

@ -572,50 +572,24 @@ export const MIN_LENGTH_VALIDATOR: any = {
providers: [MIN_LENGTH_VALIDATOR],
host: {'[attr.minlength]': 'enabled() ? minlength : null'}
})
export class MinLengthValidator implements Validator, OnChanges {
private _validator: ValidatorFn = nullValidator;
private _onChange?: () => void;
export class MinLengthValidator extends AbstractValidatorDirective implements OnChanges {
/**
* @description
* Tracks changes to the minimum length bound to this directive.
*/
@Input()
minlength!: string|number|null; // This input is always defined, since the name matches selector.
@Input() minlength!: string|number|null;
/** @internal */
override inputName = 'minlength';
/** @internal */
override normalizeInput = (input: string|number): number => toInteger(input);
/** @internal */
override createValidator = (minlength: number): ValidatorFn => minLengthValidator(minlength);
/** @nodoc */
ngOnChanges(changes: SimpleChanges): void {
if ('minlength' in changes) {
this._createValidator();
if (this._onChange) this._onChange();
}
}
/**
* Method that validates whether the value meets a minimum length requirement.
* Returns the validation result if enabled, otherwise null.
* @nodoc
*/
validate(control: AbstractControl): ValidationErrors|null {
return this.enabled() ? this._validator(control) : null;
}
/**
* Registers a callback function to call when the validator inputs change.
* @nodoc
*/
registerOnValidatorChange(fn: () => void): void {
this._onChange = fn;
}
private _createValidator(): void {
this._validator =
this.enabled() ? minLengthValidator(toInteger(this.minlength!)) : nullValidator;
}
/** @nodoc */
enabled(): boolean {
return this.minlength != null /* both `null` and `undefined` */;
this.handleChanges(changes);
}
}
@ -655,49 +629,24 @@ export const MAX_LENGTH_VALIDATOR: any = {
providers: [MAX_LENGTH_VALIDATOR],
host: {'[attr.maxlength]': 'enabled() ? maxlength : null'}
})
export class MaxLengthValidator implements Validator, OnChanges {
private _validator: ValidatorFn = nullValidator;
private _onChange?: () => void;
export class MaxLengthValidator extends AbstractValidatorDirective implements OnChanges {
/**
* @description
* Tracks changes to the maximum length bound to this directive.
* Tracks changes to the minimum length bound to this directive.
*/
@Input()
maxlength!: string|number|null; // This input is always defined, since the name matches selector.
@Input() maxlength!: string|number|null;
/** @internal */
override inputName = 'maxlength';
/** @internal */
override normalizeInput = (input: string|number): number => toInteger(input);
/** @internal */
override createValidator = (maxlength: number): ValidatorFn => maxLengthValidator(maxlength);
/** @nodoc */
ngOnChanges(changes: SimpleChanges): void {
if ('maxlength' in changes) {
this._createValidator();
if (this._onChange) this._onChange();
}
}
/**
* Method that validates whether the value exceeds the maximum length requirement.
* @nodoc
*/
validate(control: AbstractControl): ValidationErrors|null {
return this.enabled() ? this._validator(control) : null;
}
/**
* Registers a callback function to call when the validator inputs change.
* @nodoc
*/
registerOnValidatorChange(fn: () => void): void {
this._onChange = fn;
}
private _createValidator(): void {
this._validator =
this.enabled() ? maxLengthValidator(toInteger(this.maxlength!)) : nullValidator;
}
/** @nodoc */
enabled(): boolean {
return this.maxlength != null /* both `null` and `undefined` */;
this.handleChanges(changes);
}
}