From 7b2b0f40e2ea189cc15535bf3500d1d142af8806 Mon Sep 17 00:00:00 2001 From: Matthieu Riegler Date: Fri, 26 Jan 2024 20:07:59 +0100 Subject: [PATCH] refactor(core): Guard assertion with `ngDevMode` (#53764) `assertDefined` is always guarded elsewhere PR Close #53764 --- packages/core/src/render3/errors_di.ts | 2 +- packages/core/src/render3/i18n/i18n_locale_id.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/core/src/render3/errors_di.ts b/packages/core/src/render3/errors_di.ts index 292e39cf2a2..7bf41b3e359 100644 --- a/packages/core/src/render3/errors_di.ts +++ b/packages/core/src/render3/errors_di.ts @@ -20,7 +20,7 @@ export function throwCyclicDependencyError(token: string, path?: string[]): neve const depPath = path ? `. Dependency path: ${path.join(' > ')} > ${token}` : ''; throw new RuntimeError( RuntimeErrorCode.CYCLIC_DI_DEPENDENCY, - `Circular dependency in DI detected for ${token}${depPath}`); + ngDevMode ? `Circular dependency in DI detected for ${token}${depPath}` : token); } export function throwMixedMultiProviderError() { diff --git a/packages/core/src/render3/i18n/i18n_locale_id.ts b/packages/core/src/render3/i18n/i18n_locale_id.ts index 66d90748542..7fff4d11bf9 100644 --- a/packages/core/src/render3/i18n/i18n_locale_id.ts +++ b/packages/core/src/render3/i18n/i18n_locale_id.ts @@ -25,7 +25,7 @@ let LOCALE_ID = DEFAULT_LOCALE_ID; * @param localeId */ export function setLocaleId(localeId: string) { - assertDefined(localeId, `Expected localeId to be defined`); + ngDevMode && assertDefined(localeId, `Expected localeId to be defined`); if (typeof localeId === 'string') { LOCALE_ID = localeId.toLowerCase().replace(/_/g, '-'); }