From 72c12653e1cfcd7ac586e60f4d09272bfebcfc4d Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Wed, 29 Sep 2021 23:45:16 +0200 Subject: [PATCH] build(docs-infra): do not error if suites are ignored (#43431) Adding suites to the `IGNORED_EXAMPLES` array currently results in an runtime exception because later when ignored examples are printed to stdout, a non-existent variable is referenced back from when there were examples disabled due to the Ivy migration. This commit fixes the logic. PR Close #43431 --- aio/tools/examples/run-example-e2e.mjs | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/aio/tools/examples/run-example-e2e.mjs b/aio/tools/examples/run-example-e2e.mjs index b78f7a99853..be1a95272c1 100644 --- a/aio/tools/examples/run-example-e2e.mjs +++ b/aio/tools/examples/run-example-e2e.mjs @@ -311,11 +311,10 @@ function runE2eTestsCLI(appDir, outputFile, bufferOutput, port) { function reportStatus(status, outputFile) { let log = ['']; - log.push('Suites ignored due to legacy guides:'); - IGNORED_EXAMPLES.filter(example => !fixmeIvyExamples.find(ex => ex.startsWith(example))) - .forEach(function(val) { - log.push(' ' + val); - }); + log.push('Suites ignored:'); + IGNORED_EXAMPLES.forEach(function(val) { + log.push(' ' + val); + }); log.push(''); log.push('Suites passed:');