Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(migrations): speed up code refactoring action for queries (#58525)

Browse source 
We were not properly passing around the TCB full program optimization,
so TCB generation was done per individual file. This significantly
slowed down reference resolution.

PR Close #58525
This commit is contained in:
Paul Gschwendtner 2024-11-06 12:58:31 +00:00 committed by Pawel Kozlowski
parent 4a0dc3c712
commit 728bfbbb31
2 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/compiler-cli/src/ngtsc/typecheck/src/checker.ts
View file

@ -150,7 +150,7 @@ export class TemplateTypeCheckerImpl implements TemplateTypeChecker {
) {}
getTemplate(component: ts.ClassDeclaration, optimizeFor?: OptimizeFor): TmplAstNode[] | null {
const {data} = this.getLatestComponentState(component);
const {data} = this.getLatestComponentState(component, optimizeFor);
if (data === null) {
return null;
}

11
packages/core/schematics/migrations/signal-queries-migration/migration.ts
View file

@ -104,6 +104,8 @@ export class SignalQueriesMigration extends TsurgeComplexMigration<
// Pre-Analyze the program and get access to the template type checker.
const {templateTypeChecker} = info.ngCompiler['ensureAnalyzed']();
// Generate all type check blocks.
templateTypeChecker.generateAllTypeCheckBlocks();
const {sourceFiles, program} = info;
const checker = program.getTypeChecker();
@ -205,8 +207,7 @@ export class SignalQueriesMigration extends TsurgeComplexMigration<
// Ignore references to non-query class fields.
if (
this.config.assumeNonBatch &&
descriptor !== null &&
!filteredQueriesForCompilationUnit.has(descriptor.key)
(descriptor === null || !filteredQueriesForCompilationUnit.has(descriptor.key))
) {
return null;
}
@ -448,8 +449,6 @@ export class SignalQueriesMigration extends TsurgeComplexMigration<
ts.forEachChild(node, queryWholeProgramVisitor);
};
this.config.reportProgressFn?.(40, 'Tracking query declarations..');
for (const sf of info.fullProgramSourceFiles) {
ts.forEachChild(sf, queryWholeProgramVisitor);
}
@ -493,14 +492,14 @@ export class SignalQueriesMigration extends TsurgeComplexMigration<
isClassWithKnownFields: (clazz) => knownQueries.getQueryFieldsOfClass(clazz) !== undefined,
});
this.config.reportProgressFn?.(70, 'Checking inheritance..');
this.config.reportProgressFn?.(80, 'Checking inheritance..');
groupedAstVisitor.execute();
if (this.config.bestEffortMode) {
filterBestEffortIncompatibilities(knownQueries);
}
this.config.reportProgressFn?.(80, 'Migrating queries..');
this.config.reportProgressFn?.(90, 'Migrating queries..');
// Migrate declarations.
for (const extractedQuery of sourceQueries) {