From 6d9d2b83f680efb60c694b38d35dfe850c756b1f Mon Sep 17 00:00:00 2001 From: SkyZeroZx <73321943+SkyZeroZx@users.noreply.github.com> Date: Wed, 10 Dec 2025 17:17:22 -0500 Subject: [PATCH] refactor(common): remove redundant providedIn: 'root' from injection tokens Removes unnecessary declarations from injection tokens (cherry picked from commit 848557964968b9d827d353dcb8448e11ef279984) --- packages/common/http/src/interceptor.ts | 3 ++- packages/common/http/src/xsrf.ts | 2 +- packages/common/http/test/provider_spec.ts | 2 +- .../testing/src/navigation/provide_fake_platform_navigation.ts | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/common/http/src/interceptor.ts b/packages/common/http/src/interceptor.ts index 463ae98f650..98861f97b82 100644 --- a/packages/common/http/src/interceptor.ts +++ b/packages/common/http/src/interceptor.ts @@ -215,7 +215,8 @@ export const HTTP_ROOT_INTERCEPTOR_FNS = new InjectionToken( typeof ngDevMode !== 'undefined' && ngDevMode ? 'REQUESTS_CONTRIBUTE_TO_STABILITY' : '', - {providedIn: 'root', factory: () => true}, + // Providing a factory implies that the token is provided in root by default + {factory: () => true}, ); /** diff --git a/packages/common/http/src/xsrf.ts b/packages/common/http/src/xsrf.ts index 6555fbc99b5..f6e485e4de8 100644 --- a/packages/common/http/src/xsrf.ts +++ b/packages/common/http/src/xsrf.ts @@ -32,7 +32,7 @@ export const XSRF_DEFAULT_COOKIE_NAME = 'XSRF-TOKEN'; export const XSRF_COOKIE_NAME = new InjectionToken( typeof ngDevMode !== 'undefined' && ngDevMode ? 'XSRF_COOKIE_NAME' : '', { - providedIn: 'root', + // Providing a factory implies that the token is provided in root by default factory: () => XSRF_DEFAULT_COOKIE_NAME, }, ); diff --git a/packages/common/http/test/provider_spec.ts b/packages/common/http/test/provider_spec.ts index 516931cac86..1db5271adbc 100644 --- a/packages/common/http/test/provider_spec.ts +++ b/packages/common/http/test/provider_spec.ts @@ -206,7 +206,7 @@ describe('provideHttpClient', () => { it('should allow injection from an interceptor context', () => { const ALPHA = new InjectionToken('alpha', { - providedIn: 'root', + // Providing a factory implies that the token is provided in root by default factory: () => 'alpha', }); const BETA = new InjectionToken('beta', {providedIn: 'root', factory: () => 'beta'}); diff --git a/packages/common/testing/src/navigation/provide_fake_platform_navigation.ts b/packages/common/testing/src/navigation/provide_fake_platform_navigation.ts index 14d484e7884..88686a514a8 100644 --- a/packages/common/testing/src/navigation/provide_fake_platform_navigation.ts +++ b/packages/common/testing/src/navigation/provide_fake_platform_navigation.ts @@ -17,7 +17,7 @@ import { import {FakeNavigation} from './fake_navigation'; const FAKE_NAVIGATION = new InjectionToken('fakeNavigation', { - providedIn: 'root', + // Providing a factory implies that the token is provided in root by default factory: () => { const config = inject(MOCK_PLATFORM_LOCATION_CONFIG, {optional: true}); const baseFallback = 'http://_empty_/';