Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(router): avoid component ID collisions with user code (#59300)

Browse source 
Currently the `ɵEmptyOutletComponent` is very prone to generating ID collision warnings with user code, because it only has one child and no other metadata. This shows up some of our tests as well. While users can resolve it on their end, it can be confusing since they won't have any references to `ɵEmptyOutletComponent` in their own code.

These changes add an `exportAs` to it to make its component ID unique. This doesn't affect the public API of the component since users can't use it directly anyways.

PR Close #59300
This commit is contained in:
Kristiyan Kostadinov 2024-12-24 10:01:16 +02:00 committed by Jessica Janiuk
parent a088208690
commit 5ac6f065ab
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/router/src/components/empty_outlet.ts
View file

@ -23,8 +23,10 @@ export {ɵEmptyOutletComponent as EmptyOutletComponent};
* to this `EmptyOutletComponent`.
*/
@Component({
template: `<router-outlet></router-outlet>`,
template: `<router-outlet/>`,
imports: [RouterOutlet],
// Used to avoid component ID collisions with user code.
exportAs: 'emptyRouterOutlet',
})
export class ɵEmptyOutletComponent {}