Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(core): add dev mode descriptions to foreign view boundaries

Browse source 
Add descriptive text to foreign view head and tail comments in dev mode to
assist in debugging.
This commit is contained in:
leonsenft 2026-05-21 16:09:44 -07:00
parent d941c13c75
commit 549231cd56
2 changed files with 17 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/core/src/render3/foreign_view.ts
View file

@ -106,8 +106,12 @@ export function createForeignView(lContainer: LContainer, index: number): Foreig
// 5. "Render" the view by creating the head and tail nodes, populating their slots, and marking
// the view as created. This last step is normally handled by `renderView()` for native Angular
// views with template functions.
const headComment = (lView[headTNode.index] = renderer.createComment(''));
const tailComment = (lView[tailTNode.index] = renderer.createComment(''));
const headComment = (lView[headTNode.index] = renderer.createComment(
ngDevMode ? 'foreign-view-head' : '',
));
const tailComment = (lView[tailTNode.index] = renderer.createComment(
ngDevMode ? 'foreign-view-tail' : '',
));
lView[FLAGS] &= ~LViewFlags.CreationMode;
// 6. Insert the view into the container

12
packages/core/test/render3/foreign_view_spec.ts
View file

@ -123,7 +123,17 @@ describe('foreign views', () => {
vcr2.insert(viewRef);
expect(fixture.nativeElement.innerHTML).toBe(
'<div></div><!--container--><div></div><!----><span></span><span></span><!----><!--container-->',
'' +
'<div></div>' +
// First <div> container
'<!--container-->' +
'<div></div>' +
// Foreign view
'<!--foreign-view-head-->' +
'<span></span><span></span>' +
'<!--foreign-view-tail-->' +
// Second <div> container
'<!--container-->',
);
});