Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(router): Add back changes param to RouterLink ngOnChanges (#56371)

Browse source 
This parameter was removed in a recent change but is being added back to
avoid breaking code in a minor version.
While the changes parameter is not used, some code relies on it, mostly
through API misuse (extending `RouterLink`, manually calling `ngOnChanges`, etc.).

PR Close #56371
This commit is contained in:
Andrew Scott 2024-06-10 13:58:16 -07:00 committed by Andrew Kushnir
parent 3cbddd2e42
commit 4efe5000c0
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
goldens/public-api/router/index.api.md
View file

@ -810,7 +810,7 @@ class RouterLink implements OnChanges, OnDestroy {
// (undocumented)
static ngAcceptInputType_skipLocationChange: unknown;
// (undocumented)
ngOnChanges(): void;
ngOnChanges(changes?: SimpleChanges): void;
// (undocumented)
ngOnDestroy(): any;
// (undocumented)

4
packages/router/src/directives/router_link.ts
View file

@ -19,6 +19,7 @@ import {
OnDestroy,
Renderer2,
ɵRuntimeError as RuntimeError,
SimpleChanges,
ɵɵsanitizeUrlOrResourceUrl,
} from '@angular/core';
import {Subject, Subscription} from 'rxjs';
@ -260,7 +261,8 @@ export class RouterLink implements OnChanges, OnDestroy {
}
/** @nodoc */
ngOnChanges() {
// TODO(atscott): Remove changes parameter in major version as a breaking change.
ngOnChanges(changes?: SimpleChanges) {
if (
ngDevMode &&
isUrlTree(this.routerLinkInput) &&