From 4e4bbb00ad765cbb2ef9c5a309a406e59310357f Mon Sep 17 00:00:00 2001 From: Vincent Date: Thu, 21 Nov 2024 13:18:28 +0100 Subject: [PATCH] refactor(core): Make wording of effect-allowSignalWrites deprecation warning more accurate (#58792) The previous warning contained a typo and also somewhat implied that allowSignalWrites did something. However, setting allowSignalWrites to false has no impact at all in Angular 19. Closes #58790 PR Close #58792 --- packages/core/src/render3/reactivity/effect.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/render3/reactivity/effect.ts b/packages/core/src/render3/reactivity/effect.ts index eeea1cbc4ae..fb945c691ac 100644 --- a/packages/core/src/render3/reactivity/effect.ts +++ b/packages/core/src/render3/reactivity/effect.ts @@ -169,7 +169,7 @@ export function effect( if (ngDevMode && options?.allowSignalWrites !== undefined) { console.warn( - `The 'allowSignalWrites' flag is deprecated & longer required for effect() (writes are allowed by default)`, + `The 'allowSignalWrites' flag is deprecated and no longer impacts effect() (writes are always allowed)`, ); }