Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(bazel): remove experimental_extended_template_diagnostics flag (#46898)

Browse source 
Extended diagnostics are enabled by default now and this flag doesn't do anything anymore but I missed it in a previous cleanup.

PR Close #46898
This commit is contained in:
Doug Parker 2022-07-19 18:03:33 -07:00 committed by Andrew Kushnir
parent 3562eb107d
commit 4e328c47be
2 changed files with 0 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/bazel/src/ng_module/ng_module.bzl
View file

@ -191,9 +191,6 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
if not ctx.attr.type_check and ctx.attr.strict_templates:
fail("Cannot set type_check = False and strict_templates = True for ng_module()")
if ctx.attr.experimental_extended_template_diagnostics and not ctx.attr.strict_templates:
fail("Cannot set `experimental_extended_template_diagnostics = True` **and** `strict_templates = False` for `ng_module()`")
angular_compiler_options = {
"enableResourceInlining": ctx.attr.inline_resources,
"generateCodeForLibraries": False,
@ -503,10 +500,6 @@ NG_MODULE_ATTRIBUTES = {
"filter_summaries": attr.bool(default = False),
"type_check": attr.bool(default = True),
"strict_templates": attr.bool(default = False),
"experimental_extended_template_diagnostics": attr.bool(
default = False,
doc = "Experimental option, not publicly supported.",
),
"inline_resources": attr.bool(default = True),
"no_i18n": attr.bool(default = False),
"compiler": attr.label(

1
packages/bazel/test/ngc-wrapped/ivy_enabled/BUILD.bazel
View file

@ -28,7 +28,6 @@ jasmine_node_test(
ng_module(
name = "test_module_warnings_lib",
srcs = ["test_module_warnings.ts"],
experimental_extended_template_diagnostics = True,
strict_templates = True,
tags = [],
deps = ["//packages/core"],