From 4cb4e984fb4bfc09cfa9ffe0e97e55116801a04d Mon Sep 17 00:00:00 2001 From: Matthieu Riegler Date: Wed, 3 Jan 2024 00:14:49 +0100 Subject: [PATCH] refactor(core): remove duplicate stringify (#53751) `throwProviderNotFoundError` already stringifies for error. Also let's restrain the paramter type. PR Close #53751 --- packages/core/src/di/inject_switch.ts | 2 +- packages/core/src/render3/errors_di.ts | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/core/src/di/inject_switch.ts b/packages/core/src/di/inject_switch.ts index a780c13a75d..ce26489e4e8 100644 --- a/packages/core/src/di/inject_switch.ts +++ b/packages/core/src/di/inject_switch.ts @@ -59,7 +59,7 @@ export function injectRootLimpMode( } if (flags & InjectFlags.Optional) return null; if (notFoundValue !== undefined) return notFoundValue; - throwProviderNotFoundError(stringify(token), 'Injector'); + throwProviderNotFoundError(token, 'Injector'); } diff --git a/packages/core/src/render3/errors_di.ts b/packages/core/src/render3/errors_di.ts index b407a5ec2df..292e39cf2a2 100644 --- a/packages/core/src/render3/errors_di.ts +++ b/packages/core/src/render3/errors_di.ts @@ -6,6 +6,7 @@ * found in the LICENSE file at https://angular.io/license */ +import type {ProviderToken} from '../di'; import {isEnvironmentProviders} from '../di/interface/provider'; import {RuntimeError, RuntimeErrorCode} from '../errors'; import {Type} from '../interface/type'; @@ -50,7 +51,8 @@ export function throwInvalidProviderError( /** Throws an error when a token is not found in DI. */ -export function throwProviderNotFoundError(token: any, injectorName?: string): never { +export function throwProviderNotFoundError( + token: ProviderToken, injectorName?: string): never { const errorMessage = ngDevMode && `No provider for ${stringifyForError(token)} found${ injectorName ? ` in ${injectorName}` : ''}`;