From 461eeda6d9fd64c18b158dbc04ce8d58f58c8a8d Mon Sep 17 00:00:00 2001 From: Alan Agius <17563226+alan-agius4@users.noreply.github.com> Date: Thu, 9 Oct 2025 06:09:54 +0000 Subject: [PATCH] build: remove unneeded language-service dependency (#64306) The `@angular/language-service` package was not needed for integration tests or benchmarks. Removing this dependency simplifies the build configuration. PR Close #64306 --- integration/legacy-animations/package.json | 1 - integration/legacy-animations/pnpm-lock.yaml | 3 --- integration/package.json | 1 - packages.bzl | 2 +- packages/language-service/BUILD.bazel | 5 +---- pnpm-lock.yaml | 10 +++------- 6 files changed, 5 insertions(+), 17 deletions(-) diff --git a/integration/legacy-animations/package.json b/integration/legacy-animations/package.json index 0eb0dce3f7d..d087fe58b35 100644 --- a/integration/legacy-animations/package.json +++ b/integration/legacy-animations/package.json @@ -26,7 +26,6 @@ "@angular-devkit/build-angular": "21.0.0-next.7", "@angular/cli": "21.0.0-next.7", "@angular/compiler-cli": "link:./in-existing-linked-by-bazel", - "@angular/language-service": "link:./in-existing-linked-by-bazel", "@types/jasmine": "^5.0.0", "@types/jasminewd2": "^2.0.8", "@types/node": "^20.14.8", diff --git a/integration/legacy-animations/pnpm-lock.yaml b/integration/legacy-animations/pnpm-lock.yaml index 9a26a2562ca..0eb427a21b3 100644 --- a/integration/legacy-animations/pnpm-lock.yaml +++ b/integration/legacy-animations/pnpm-lock.yaml @@ -45,9 +45,6 @@ importers: '@angular/compiler-cli': specifier: link:./in-existing-linked-by-bazel version: link:in-existing-linked-by-bazel - '@angular/language-service': - specifier: link:./in-existing-linked-by-bazel - version: link:in-existing-linked-by-bazel '@types/jasmine': specifier: ^5.0.0 version: 5.1.9 diff --git a/integration/package.json b/integration/package.json index 4d545f5f2cb..f3a8982c061 100644 --- a/integration/package.json +++ b/integration/package.json @@ -8,7 +8,6 @@ "@angular/core": "workspace:*", "@angular/elements": "workspace:*", "@angular/forms": "workspace:*", - "@angular/language-service": "workspace: *", "@angular/localize": "workspace: *", "@angular/platform-browser-dynamic": "workspace:*", "@angular/platform-browser": "workspace:*", diff --git a/packages.bzl b/packages.bzl index f5cbde4db24..8dc4f0de752 100644 --- a/packages.bzl +++ b/packages.bzl @@ -50,7 +50,7 @@ UNPUBLISHED_PACKAGES = [ ALL_PACKAGES = PUBLISHED_PACKAGES + UNPUBLISHED_PACKAGES # Packages used by integration tests -INTEGRATION_PACKAGES = _exclude_pkgs(PUBLISHED_PACKAGES, "zone.js", "angular-in-memory-web-api") +INTEGRATION_PACKAGES = _exclude_pkgs(PUBLISHED_PACKAGES, "@angular/language-service", "zone.js", "angular-in-memory-web-api") # Package names under //packages that have `files_for_docgen` targets DOCS_ENTRYPOINTS = [ diff --git a/packages/language-service/BUILD.bazel b/packages/language-service/BUILD.bazel index 1e99f415519..6dc3f99e4cd 100644 --- a/packages/language-service/BUILD.bazel +++ b/packages/language-service/BUILD.bazel @@ -63,8 +63,5 @@ npm_package( ], # Do not add more to this list. # Dependencies on the full npm_package cause long re-builds. - visibility = [ - "//integration:__subpackages__", - "//modules/ssr-benchmarks:__subpackages__", - ], + visibility = [], ) diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index c9484bb21fb..81f30a583c9 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -833,9 +833,6 @@ importers: '@angular/forms': specifier: workspace:* version: link:../packages/forms - '@angular/language-service': - specifier: 'workspace: *' - version: link:../packages/language-service '@angular/localize': specifier: 'workspace: *' version: link:../packages/localize @@ -1401,7 +1398,7 @@ importers: devDependencies: ng-packagr: specifier: 21.0.0-next.4 - version: 21.0.0-next.4(@angular/compiler-cli@21.0.0-next.7(@angular/compiler@21.0.0-next.7)(typescript@5.9.3))(tailwindcss@3.4.18(ts-node@10.9.2(@types/node@20.19.17)(typescript@5.9.3)))(tslib@2.8.1)(typescript@5.9.3) + version: 21.0.0-next.4(@angular/compiler-cli@21.0.0-next.7(@angular/compiler@21.0.0-next.7)(typescript@5.9.3))(tailwindcss@3.4.18(ts-node@10.9.2(@types/node@24.7.0)(typescript@5.9.3)))(tslib@2.8.1)(typescript@5.9.3) typescript: specifier: 5.9.3 version: 5.9.3 @@ -10641,7 +10638,6 @@ packages: engines: {node: '>=0.6.0', teleport: '>=0.2.0'} deprecated: |- You or someone you depend on is using Q, the JavaScript Promise library that gave JavaScript developers strong feelings about promises. They can almost certainly migrate to the native JavaScript promise now. Thank you literally everyone for joining me in this bet against the odds. Be excellent to each other. - (For a CapTP with native promises, see @endo/eventual-send and @endo/captp) qjobs@1.2.0: @@ -23445,7 +23441,7 @@ snapshots: netmask@2.0.2: {} - ng-packagr@21.0.0-next.4(@angular/compiler-cli@21.0.0-next.7(@angular/compiler@21.0.0-next.7)(typescript@5.9.3))(tailwindcss@3.4.18(ts-node@10.9.2(@types/node@20.19.17)(typescript@5.9.3)))(tslib@2.8.1)(typescript@5.9.3): + ng-packagr@21.0.0-next.4(@angular/compiler-cli@21.0.0-next.7(@angular/compiler@21.0.0-next.7)(typescript@5.9.3))(tailwindcss@3.4.18(ts-node@10.9.2(@types/node@24.7.0)(typescript@5.9.3)))(tslib@2.8.1)(typescript@5.9.3): dependencies: '@ampproject/remapping': 2.3.0 '@angular/compiler-cli': 21.0.0-next.7(@angular/compiler@21.0.0-next.7)(typescript@5.9.3) @@ -23473,7 +23469,7 @@ snapshots: typescript: 5.9.3 optionalDependencies: rollup: 4.52.3 - tailwindcss: 3.4.18(ts-node@10.9.2(@types/node@20.19.17)(typescript@5.9.3)) + tailwindcss: 3.4.18(ts-node@10.9.2(@types/node@24.7.0)(typescript@5.9.3)) ng-packagr@21.0.0-next.4(@angular/compiler-cli@packages+compiler-cli)(tailwindcss@3.4.18(ts-node@10.9.2(@types/node@20.19.17)(typescript@5.9.3)))(tslib@2.8.1)(typescript@5.9.3): dependencies: