From 44f9f0108ecda1c8a805f9912bfaa656149d0a6d Mon Sep 17 00:00:00 2001
From: Andrew Scott <atscott@google.com>
Date: Thu, 7 Dec 2023 14:59:20 -0800
Subject: [PATCH] refactor(core): Update flaky test with wait condition
 (#53437)

The tests in this commit have been flaky commonly due to the elements
not being found. Hopefully using `ExpectedConditions` helps.

PR Close #53437
---
 .../examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts   | 4 +++-
 .../examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts   | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/adev/src/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts b/adev/src/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts
index b7c0eef894f..33ea8d11965 100644
--- a/adev/src/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts
+++ b/adev/src/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts
@@ -1,4 +1,4 @@
-import { element, by } from 'protractor';
+import { element, by, ExpectedConditions, browser } from 'protractor';
 import { AppPage } from './app.po';
 
 
@@ -22,6 +22,7 @@ describe('providers App', () => {
 
     it('should show customers when the button is clicked', async () => {
       const customersMessage = element(by.css('app-customers > p'));
+      await browser.wait(ExpectedConditions.visibilityOf(customersMessage));
       expect(await customersMessage.getText()).toBe('customers works!');
     });
 
@@ -32,6 +33,7 @@ describe('providers App', () => {
 
     it('should show orders when the button is clicked', async () => {
       const ordersMessage = element(by.css('app-orders > p'));
+      await browser.wait(ExpectedConditions.visibilityOf(ordersMessage));
       expect(await ordersMessage.getText()).toBe('orders works!');
     });
 
diff --git a/aio/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts b/aio/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts
index b7c0eef894f..33ea8d11965 100644
--- a/aio/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts
+++ b/aio/content/examples/lazy-loading-ngmodules/e2e/src/app.e2e-spec.ts
@@ -1,4 +1,4 @@
-import { element, by } from 'protractor';
+import { element, by, ExpectedConditions, browser } from 'protractor';
 import { AppPage } from './app.po';
 
 
@@ -22,6 +22,7 @@ describe('providers App', () => {
 
     it('should show customers when the button is clicked', async () => {
       const customersMessage = element(by.css('app-customers > p'));
+      await browser.wait(ExpectedConditions.visibilityOf(customersMessage));
       expect(await customersMessage.getText()).toBe('customers works!');
     });
 
@@ -32,6 +33,7 @@ describe('providers App', () => {
 
     it('should show orders when the button is clicked', async () => {
       const ordersMessage = element(by.css('app-orders > p'));
+      await browser.wait(ExpectedConditions.visibilityOf(ordersMessage));
       expect(await ordersMessage.getText()).toBe('orders works!');
     });