From 3e8e9483db79bf0d60acf80da342ccc4a8c25bc2 Mon Sep 17 00:00:00 2001 From: Alex Rickabaugh Date: Thu, 5 Dec 2024 13:00:07 -0800 Subject: [PATCH] refactor(compiler-cli): remove circular dep in the partial evaluator (#59083) Use `import type` to break a phantom import cycle. PR Close #59083 --- goldens/circular-deps/packages.json | 4 ---- .../src/ngtsc/partial_evaluator/src/interpreter.ts | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json index 536cb5ee432..bf2e982e71a 100644 --- a/goldens/circular-deps/packages.json +++ b/goldens/circular-deps/packages.json @@ -1,8 +1,4 @@ [ - [ - "packages/compiler-cli/src/ngtsc/partial_evaluator/src/interface.ts", - "packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts" - ], [ "packages/compiler/src/output/output_ast.ts", "packages/compiler/src/render3/view/i18n/meta.ts" diff --git a/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts b/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts index 157a7da833b..1374eda6e86 100644 --- a/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts +++ b/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts @@ -16,7 +16,7 @@ import {isDeclaration} from '../../util/src/typescript'; import {ArrayConcatBuiltinFn, ArraySliceBuiltinFn, StringConcatBuiltinFn} from './builtin'; import {DynamicValue} from './dynamic'; -import {ForeignFunctionResolver} from './interface'; +import type {ForeignFunctionResolver} from './interface'; import { EnumValue, KnownFn,