Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(devtools): injector tree root refocus on CD (#62987)

Browse source 
Fixes the unwanted root node refocus on change detection in the Injector Tree visualizations.

PR Close #62987
This commit is contained in:
hawkgs 2025-08-04 16:40:51 +03:00 committed by Kristiyan Kostadinov
parent 0305dcdfc6
commit 3d9fc3e09c
1 changed files with 15 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
devtools/projects/ng-devtools/src/lib/devtools-tabs/injector-tree/injector-tree.component.ts
View file

@ -27,7 +27,7 @@ import {
SerializedProviderRecord,
} from '../../../../../protocol';
import {TreeVisualizer} from '../../shared/tree-visualizer-host/tree-visualizer';
import {TreeD3Node, TreeVisualizer} from '../../shared/tree-visualizer-host/tree-visualizer';
import {TreeVisualizerHostComponent} from '../../shared/tree-visualizer-host/tree-visualizer-host.component';
import {InjectorProvidersComponent} from './injector-providers/injector-providers.component';
import {
@ -39,6 +39,7 @@ import {
getInjectorIdsToRootFromNode,
grabInjectorPathsFromDirectiveForest,
InjectorTreeD3Node,
InjectorTreeNode,
InjectorTreeVisualizer,
splitInjectorPathsIntoElementAndEnvironmentPaths,
transformInjectorResolutionPathsIntoTree,
@ -245,35 +246,28 @@ export class InjectorTreeComponent {
});
}
checkIfSelectedNodeStillExists(): void {
reselectSelectedNode(): void {
const selectedNode = this.selectedNode();
if (selectedNode === null) {
this.snapToRoot(this.injectorTreeGraph);
this.snapToRoot(this.elementInjectorTreeGraph);
if (!selectedNode) {
return;
}
const injector = selectedNode.data.injector;
let newNode: TreeD3Node<InjectorTreeNode> | null = null;
if (injector.type === 'element') {
const node = this.elementInjectorTreeGraph.getNodeById(injector.id);
if (node) {
this.selectedNode.set(node);
return;
}
newNode = this.elementInjectorTreeGraph.getNodeById(injector.id);
} else if (injector.type === 'environment') {
newNode = this.injectorTreeGraph.getNodeById(injector.id);
}
if (injector.type === 'environment') {
const node = this.injectorTreeGraph.getNodeById(injector.id);
if (node) {
this.selectedNode.set(node);
return;
}
if (newNode) {
this.selectedNode.set(newNode);
} else {
this.selectedNode.set(null);
this.snapToRoot(this.injectorTreeGraph);
this.snapToRoot(this.elementInjectorTreeGraph);
}
this.selectedNode.set(null);
this.snapToRoot(this.injectorTreeGraph);
this.snapToRoot(this.elementInjectorTreeGraph);
}
getNodeByComponentId(graph: InjectorTreeVisualizer, id: number): InjectorTreeD3Node | null {
@ -339,7 +333,7 @@ export class InjectorTreeComponent {
this.unhighlightAllEdges(envGroup);
this.unhighlightAllNodes(envGroup);
this.checkIfSelectedNodeStillExists();
this.reselectSelectedNode();
if (this.selectedNode() === null) {
return;