Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(common): log a warning when a JsonPipe receives a signal

Browse source 
The JsonPipe does not unwrap signals and `JSON.stringify` will return `undefined` for signals.
To avoid confusion, we log a warning when a signal is passed to the pipe.

(cherry picked from commit 0d652ba4da)
This commit is contained in:
Matthieu Riegler 2026-02-10 15:04:45 +01:00 committed by Jessica Janiuk
parent b5eea233df
commit 3c4deaa52b
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/common/src/pipes/json_pipe.ts
View file

@ -6,7 +6,7 @@
* found in the LICENSE file at https://angular.dev/license
*/
import {Pipe, PipeTransform} from '@angular/core';
import {isSignal, Pipe, PipeTransform} from '@angular/core';
/**
* @ngModule CommonModule
@ -34,6 +34,10 @@ export class JsonPipe implements PipeTransform {
* @param value A value of any type to convert into a JSON-format string.
*/
transform(value: any): string {
if (ngDevMode && isSignal(value)) {
console.warn(`The JsonPipe does not unwrap signals. Received a signal with value:`, value());
}
return JSON.stringify(value, null, 2);
}
}