From 367b075d151d9f69b391e36ea02b1ef5637be8fd Mon Sep 17 00:00:00 2001 From: Andrew Kushnir Date: Fri, 29 Sep 2023 17:33:57 -0700 Subject: [PATCH] test(core): enable previously failing @defer tests (#51965) This commit re-enables previously flaky tests. The original issue was resolved by mocking `requestIdleCallback` in tests. PR Close #51965 --- packages/core/test/acceptance/defer_spec.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/packages/core/test/acceptance/defer_spec.ts b/packages/core/test/acceptance/defer_spec.ts index 70a13977455..1a0c3c2db74 100644 --- a/packages/core/test/acceptance/defer_spec.ts +++ b/packages/core/test/acceptance/defer_spec.ts @@ -901,8 +901,7 @@ describe('@defer', () => { expect(fixture.nativeElement.outerHTML).toContain('Rendering primary block'); }); - // TODO(akushnir): investigate why this test is flaky, fix and re-enable. - xit('should support `prefetch on idle` condition', async () => { + it('should support `prefetch on idle` condition', async () => { @Component({ selector: 'nested-cmp', standalone: true, @@ -982,8 +981,7 @@ describe('@defer', () => { expect(loadingFnInvokedTimes).toBe(1); }); - // TODO(akushnir): investigate why this test is flaky, fix and re-enable. - xit('should trigger prefetching based on `on idle` only once', async () => { + it('should trigger prefetching based on `on idle` only once', async () => { @Component({ selector: 'nested-cmp', standalone: true, @@ -1067,8 +1065,7 @@ describe('@defer', () => { expect(loadingFnInvokedTimes).toBe(1); }); - // TODO(akushnir): investigate why this test is flaky, fix and re-enable. - xit('should trigger fetching based on `on idle` only once', async () => { + it('should trigger fetching based on `on idle` only once', async () => { @Component({ selector: 'nested-cmp', standalone: true,