Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

refactor(migrations): add the ability to remove imports in the change tracker (#57179)

Browse source 
Updates the `ChangeTracker` to integrate the changes from #57110.

PR Close #57179
This commit is contained in:
Kristiyan Kostadinov 2024-07-29 10:40:47 +02:00 committed by Dylan Hunn
parent 67e09404db
commit 2ffa417665
1 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
packages/core/schematics/utils/change_tracker.ts
View file

@ -140,6 +140,25 @@ export class ChangeTracker {
});
}
/**
* Removes an import from a file.
* @param sourceFile File from which to remove the import.
* @param symbolName Original name of the symbol to be removed. Used even if the import is aliased.
* @param moduleName Module from which the symbol is imported.
*/
removeImport(sourceFile: ts.SourceFile, symbolName: string, moduleName: string): void {
// It's common for paths to be manipulated with Node's `path` utilties which
// can yield a path with back slashes. Normalize them since outputting such
// paths will also cause TS to escape the forward slashes.
moduleName = normalizePath(moduleName);
if (!this._changes.has(sourceFile)) {
this._changes.set(sourceFile, []);
}
this._importManager.removeImport(sourceFile, symbolName, moduleName);
}
/**
* Gets the changes that should be applied to all the files in the migration.
* The changes are sorted in the order in which they should be applied.
@ -201,12 +220,16 @@ export class ChangeTracker {
/** Records the pending import changes from the import manager. */
private _recordImports(): void {
const {newImports, updatedImports} = this._importManager.finalize();
const {newImports, updatedImports, deletedImports} = this._importManager.finalize();
for (const [original, replacement] of updatedImports) {
this.replaceNode(original, replacement);
}
for (const node of deletedImports) {
this.removeNode(node);
}
for (const [sourceFile] of this._changes) {
const importsToAdd = newImports.get(sourceFile.fileName);