Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

docs: add a callout that adding/removing to formArray doesn't not mark dirty (#64337)

Browse source 
fixes #36788

PR Close #64337
This commit is contained in:
Matthieu Riegler 2025-10-10 15:18:43 +02:00 committed by Andrew Kushnir
parent dc37100538
commit 2ecbc4e643
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/forms/src/model/form_array.ts
View file

@ -174,6 +174,8 @@ export class FormArray<TControl extends AbstractControl<any> = any> extends Abst
* * `emitEvent`: When true or not supplied (the default), both the `statusChanges` and
* `valueChanges` observables emit events with the latest status and value when the control is
* inserted. When false, no events are emitted.
*
* NOTE: Pushing to the FormArray will not mark it dirty. If you want to mark if dirty, call `markAsDirty()`.
*/
push(control: TControl | Array<TControl>, options: {emitEvent?: boolean} = {}): void {
if (Array.isArray(control)) {
@ -201,6 +203,8 @@ export class FormArray<TControl extends AbstractControl<any> = any> extends Abst
* * `emitEvent`: When true or not supplied (the default), both the `statusChanges` and
* `valueChanges` observables emit events with the latest status and value when the control is
* inserted. When false, no events are emitted.
*
* NOTE: Inserting to the FormArray will not mark it dirty. If you want to mark if dirty, call `markAsDirty()`.
*/
insert(index: number, control: TControl, options: {emitEvent?: boolean} = {}): void {
this.controls.splice(index, 0, control);
@ -220,6 +224,8 @@ export class FormArray<TControl extends AbstractControl<any> = any> extends Abst
* * `emitEvent`: When true or not supplied (the default), both the `statusChanges` and
* `valueChanges` observables emit events with the latest status and value when the control is
* removed. When false, no events are emitted.
*
* NOTE: Removing the FormArray will not mark it dirty. If you want to mark if dirty, call `markAsDirty()`.
*/
removeAt(index: number, options: {emitEvent?: boolean} = {}): void {
// Adjust the index, then clamp it at no less than 0 to prevent undesired underflows.