Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Revert "fix(core): add additional component metadata to component ID generation (#50203)" (#50334)

Browse source 
This reverts commit 52c74d3b4a.

The reason for revert: breaking some apps in Google's codebase.

PR Close #50334
This commit is contained in:
Andrew Kushnir 2023-05-16 12:46:58 -07:00
parent a898d9fd03
commit 237d90f4e3
1 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/core/src/render3/definition.ts
View file

@ -686,7 +686,7 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
// https://github.com/angular/components/blob/d9f82c8f95309e77a6d82fd574c65871e91354c2/src/material/core/option/option.ts#L248
// https://github.com/angular/components/blob/285f46dc2b4c5b127d356cb7c4714b221f03ce50/src/material/legacy-core/option/option.ts#L32
const hashSelectors = JSON.stringify([
const hashSelectors = [
componentDef.selectors,
componentDef.ngContentSelectors,
componentDef.hostVars,
@ -696,16 +696,12 @@ function getComponentId(componentDef: ComponentDef<unknown>): string {
componentDef.decls,
componentDef.encapsulation,
componentDef.standalone,
componentDef.signals,
componentDef.exportAs,
componentDef.inputs,
componentDef.outputs,
// We cannot use 'componentDef.type.name' as the name of the symbol will change and will not
// match in the server and browser bundles.
Object.getOwnPropertyNames(componentDef.type.prototype),
!!componentDef.contentQueries,
!!componentDef.viewQuery,
]);
].join('|');
for (const char of hashSelectors) {
hash = Math.imul(31, hash) + char.charCodeAt(0) << 0;