Elgato_dark/angular
1
0
Fork 0
mirror of https://github.com/angular/angular synced 2026-05-24 09:28:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(forms): fix FormRecord type inference (#50750)

Browse source 
Updates type inference in `ɵElement` to make `FormRecord` take precedence over `FormGroup`

PR Close #50750
This commit is contained in:
emmanuelroux 2023-06-17 20:24:58 +02:00 committed by Andrew Kushnir
parent 9762b24b5e
commit 18b6f3339f
1 changed files with 16 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
packages/forms/src/form_builder.ts
View file

@ -75,24 +75,28 @@ export type ɵElement<T, N extends null> =
// through the distributive conditional type. This is the officially recommended solution:
// https://www.typescriptlang.org/docs/handbook/2/conditional-types.html#distributive-conditional-types
//
// Note: Because `FormRecord` implementation extends `FormGroup`, it must be checked BEFORE `FormGroup`
// in the following clauses (otherwise it may incorrectly be inferred to `FormGroup`).
//
//
// Identify FormControl container types.
[T] extends [FormControl<infer U>]
? FormControl<U>
: // Or FormControl containers that are optional in their parent group.
[T] extends [FormControl<infer U> | undefined]
? FormControl<U>
: // FormGroup containers.
[T] extends [FormGroup<infer U>]
? FormGroup<U>
: // Optional FormGroup containers.
[T] extends [FormGroup<infer U> | undefined]
? FormGroup<U>
: // FormRecord containers.
[T] extends [FormRecord<infer U>]
? FormRecord<U>
: // Optional FormRecord containers.
[T] extends [FormRecord<infer U> | undefined]
? FormRecord<U>
: // FormRecord containers.
[T] extends [FormRecord<infer U>]
? FormRecord<U>
: // Optional FormRecord containers.
[T] extends [FormRecord<infer U> | undefined]
? FormRecord<U>
: // FormGroup containers.
[T] extends [FormGroup<infer U>]
? FormGroup<U>
: // Optional FormGroup containers.
[T] extends [FormGroup<infer U> | undefined]
? FormGroup<U>
: // FormArray containers.
[T] extends [FormArray<infer U>]
? FormArray<U>