From 039bcad76ac5aa65c8dcacde8e7699e87bb504d0 Mon Sep 17 00:00:00 2001
From: Alex Rickabaugh <alx+alxhub@alxandria.net>
Date: Thu, 5 Dec 2024 13:07:52 -0800
Subject: [PATCH] refactor(core): remove circular dep in iterable differs.
 (#59083)

Use `import type` to break a phantom circular import in iterable differs.

PR Close #59083
---
 goldens/circular-deps/packages.json                       | 8 --------
 .../change_detection/differs/default_iterable_differ.ts   | 2 +-
 .../change_detection/differs/default_keyvalue_differ.ts   | 2 +-
 3 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/goldens/circular-deps/packages.json b/goldens/circular-deps/packages.json
index dc49a375b80..56f1cd2b2b9 100644
--- a/goldens/circular-deps/packages.json
+++ b/goldens/circular-deps/packages.json
@@ -1,12 +1,4 @@
 [
-  [
-    "packages/core/src/change_detection/differs/default_iterable_differ.ts",
-    "packages/core/src/change_detection/differs/iterable_differs.ts"
-  ],
-  [
-    "packages/core/src/change_detection/differs/default_keyvalue_differ.ts",
-    "packages/core/src/change_detection/differs/keyvalue_differs.ts"
-  ],
   [
     "packages/core/src/di/injectable.ts",
     "packages/core/src/di/jit/injectable.ts"
diff --git a/packages/core/src/change_detection/differs/default_iterable_differ.ts b/packages/core/src/change_detection/differs/default_iterable_differ.ts
index 5351147a3da..d37948b1095 100644
--- a/packages/core/src/change_detection/differs/default_iterable_differ.ts
+++ b/packages/core/src/change_detection/differs/default_iterable_differ.ts
@@ -11,7 +11,7 @@ import {Writable} from '../../interface/type';
 import {isListLikeIterable, iterateListLike} from '../../util/iterable';
 import {stringify} from '../../util/stringify';
 
-import {
+import type {
   IterableChangeRecord,
   IterableChanges,
   IterableDiffer,
diff --git a/packages/core/src/change_detection/differs/default_keyvalue_differ.ts b/packages/core/src/change_detection/differs/default_keyvalue_differ.ts
index 2a2c13547e0..9be4c094d23 100644
--- a/packages/core/src/change_detection/differs/default_keyvalue_differ.ts
+++ b/packages/core/src/change_detection/differs/default_keyvalue_differ.ts
@@ -10,7 +10,7 @@ import {RuntimeError, RuntimeErrorCode} from '../../errors';
 import {isJsObject} from '../../util/iterable';
 import {stringify} from '../../util/stringify';
 
-import {
+import type {
   KeyValueChangeRecord,
   KeyValueChanges,
   KeyValueDiffer,