From 00d56e4eadb0675c386216f3faefbf77ea18a5b2 Mon Sep 17 00:00:00 2001 From: George Kalpakas Date: Mon, 30 Nov 2020 23:46:14 +0200 Subject: [PATCH] ci: enable the Selenium Promise Manager in AIO e2e tests to avoid flakiness on CI (#39905) Since we turned off the Selenium Promise Manager in #39600, the AIO e2e tests have started flaking on CI. After trying out several things, the only change that seems to eliminate the flakiness is turning the Selenium Promise Manager back on (see #39873 for more details). This commit turns the Selenium Project Manager on to get rid of the flakiness. Fixes #39872 PR Close #39905 --- aio/tests/e2e/protractor.conf.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/aio/tests/e2e/protractor.conf.js b/aio/tests/e2e/protractor.conf.js index 6a001318935..f11670a4032 100644 --- a/aio/tests/e2e/protractor.conf.js +++ b/aio/tests/e2e/protractor.conf.js @@ -21,7 +21,12 @@ exports.config = { }, }, directConnect: true, - SELENIUM_PROMISE_MANAGER: false, + // Keep the Selenium Promise Manager enabled to avoid flakiness on CI. + // See https://github.com/angular/angular/issues/39872 for more details. + // + // TODO(gkalpak): Set this back to `false` to align with CLI-generated apps when the flakiness is + // fixed in the future. + SELENIUM_PROMISE_MANAGER: true, baseUrl: 'http://localhost:4200/', framework: 'jasmine', jasmineNodeOpts: {