mirror of
https://github.com/ToolJet/ToolJet
synced 2026-04-30 18:07:20 +00:00
* Initial commit * git auth * git sso * Git sso * Git Oauth rebase * review comments * added email validation * improvement * Package lock revert * E2E test case fix * fix data population in migration * Supress initial error thrown by google * Fix * e2e test cases * added e2e test cases * isValidDomain improvement * e2e test cases fix Co-authored-by: Akshay Sasidharan <akshaysasidharan93@gmail.com>
461 lines
14 KiB
TypeScript
461 lines
14 KiB
TypeScript
import * as request from 'supertest';
|
|
import { INestApplication } from '@nestjs/common';
|
|
import { clearDB, createUser, createNestAppInstanceWithEnvMock } from '../test.helper';
|
|
import { OAuth2Client } from 'google-auth-library';
|
|
import { mocked } from 'ts-jest/utils';
|
|
import got from 'got';
|
|
|
|
jest.mock('got');
|
|
const mockedGot = mocked(got);
|
|
|
|
describe('oauth controller', () => {
|
|
let app: INestApplication;
|
|
let mockConfig;
|
|
|
|
beforeEach(async () => {
|
|
await clearDB();
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
if (key === 'SSO_DISABLE_SIGNUP') {
|
|
return 'false';
|
|
} else {
|
|
return process.env[key];
|
|
}
|
|
});
|
|
});
|
|
|
|
beforeAll(async () => {
|
|
({ app, mockConfig } = await createNestAppInstanceWithEnvMock());
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.resetAllMocks();
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
describe('sign in via Google OAuth', () => {
|
|
it('should return login info when the user does not exist', async () => {
|
|
const googleVerifyMock = jest.spyOn(OAuth2Client.prototype, 'verifyIdToken');
|
|
googleVerifyMock.mockImplementation(() => ({
|
|
getPayload: () => ({
|
|
sub: 'someSSOId',
|
|
email: 'ssoUser@tooljet.io',
|
|
name: 'SSO User',
|
|
hd: 'tooljet.io',
|
|
}),
|
|
}));
|
|
|
|
// Calling the createUser helper function to have an Organization created. This user is irrelevant for the test
|
|
await createUser(app, { email: 'anotherUser@tooljet.io', role: 'admin' });
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'google' });
|
|
|
|
expect(googleVerifyMock).toHaveBeenCalledWith({
|
|
idToken: token,
|
|
audience: undefined,
|
|
});
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
expect(Object.keys(response.body).sort()).toEqual(
|
|
[
|
|
'id',
|
|
'email',
|
|
'first_name',
|
|
'last_name',
|
|
'auth_token',
|
|
'admin',
|
|
'group_permissions',
|
|
'app_group_permissions',
|
|
].sort()
|
|
);
|
|
|
|
const { email, first_name, last_name, admin, group_permissions, app_group_permissions } = response.body;
|
|
|
|
expect(email).toEqual('ssoUser@tooljet.io');
|
|
expect(first_name).toEqual('SSO');
|
|
expect(last_name).toEqual('User');
|
|
expect(admin).toBeFalsy();
|
|
expect(group_permissions).toHaveLength(1);
|
|
expect(group_permissions[0].group).toEqual('all_users');
|
|
expect(Object.keys(group_permissions[0]).sort()).toEqual(
|
|
[
|
|
'id',
|
|
'organization_id',
|
|
'group',
|
|
'app_create',
|
|
'app_delete',
|
|
'updated_at',
|
|
'created_at',
|
|
'folder_create',
|
|
].sort()
|
|
);
|
|
expect(app_group_permissions).toHaveLength(0);
|
|
});
|
|
|
|
it('should be forbid logging in when the user does not exist and signups are disabled', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
if (key === 'SSO_DISABLE_SIGNUP') {
|
|
return 'true';
|
|
} else {
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const googleVerifyMock = jest.spyOn(OAuth2Client.prototype, 'verifyIdToken');
|
|
googleVerifyMock.mockImplementation(() => ({
|
|
getPayload: () => ({
|
|
sub: 'someSSOId',
|
|
email: 'ssoUser@tooljet.io',
|
|
name: 'SSO User',
|
|
hd: 'tooljet.io',
|
|
}),
|
|
}));
|
|
|
|
// Calling the createUser helper function to have an Organization created. This user is irrelevant for the test
|
|
await createUser(app, { email: 'anotherUser@tooljet.io', role: 'admin' });
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'google' });
|
|
|
|
expect(googleVerifyMock).toHaveBeenCalledWith({
|
|
idToken: token,
|
|
audience: undefined,
|
|
});
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
it('should be forbid logging in when the restricted domin is configured and domain not match', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
if (key === 'SSO_RESTRICTED_DOMAIN') {
|
|
return 'tooljet.com,tooljet.in';
|
|
} else {
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const googleVerifyMock = jest.spyOn(OAuth2Client.prototype, 'verifyIdToken');
|
|
googleVerifyMock.mockImplementation(() => ({
|
|
getPayload: () => ({
|
|
sub: 'someSSOId',
|
|
email: 'ssoUser@tooljet.io',
|
|
name: 'SSO User',
|
|
hd: 'tooljet.io',
|
|
}),
|
|
}));
|
|
|
|
// Calling the createUser helper function to have an Organization created. This user is irrelevant for the test
|
|
await createUser(app, { email: 'anotherUser@tooljet.io', role: 'admin' });
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'google' });
|
|
|
|
expect(googleVerifyMock).toHaveBeenCalledWith({
|
|
idToken: token,
|
|
audience: undefined,
|
|
});
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
it('should be success when the restricted domin is configured and domain matches', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
if (key === 'SSO_RESTRICTED_DOMAIN') {
|
|
return 'tooljet.com,tooljet.io';
|
|
} else {
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const googleVerifyMock = jest.spyOn(OAuth2Client.prototype, 'verifyIdToken');
|
|
googleVerifyMock.mockImplementation(() => ({
|
|
getPayload: () => ({
|
|
sub: 'someSSOId',
|
|
email: 'ssoUser@tooljet.io',
|
|
name: 'SSO User',
|
|
hd: 'tooljet.io',
|
|
}),
|
|
}));
|
|
|
|
// Calling the createUser helper function to have an Organization created. This user is irrelevant for the test
|
|
await createUser(app, { email: 'anotherUser@tooljet.io', role: 'admin' });
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'google' });
|
|
|
|
expect(googleVerifyMock).toHaveBeenCalledWith({
|
|
idToken: token,
|
|
audience: undefined,
|
|
});
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
});
|
|
|
|
it('should return login info when the user exists', async () => {
|
|
const googleVerifyMock = jest.spyOn(OAuth2Client.prototype, 'verifyIdToken');
|
|
googleVerifyMock.mockImplementation(() => ({
|
|
getPayload: () => ({
|
|
sub: 'someSSOId',
|
|
email: 'ssoUser@tooljet.io',
|
|
name: 'New name',
|
|
hd: 'tooljet.io',
|
|
}),
|
|
}));
|
|
|
|
await createUser(app, {
|
|
email: 'ssoUser@tooljet.io',
|
|
role: 'developer',
|
|
ssoId: 'someSSOId',
|
|
firstName: 'Existing',
|
|
lastName: 'Name',
|
|
groups: ['all_users', 'admin'],
|
|
});
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'google' });
|
|
|
|
expect(googleVerifyMock).toHaveBeenCalledWith({
|
|
idToken: token,
|
|
audience: undefined,
|
|
});
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
expect(new Set(Object.keys(response.body))).toEqual(
|
|
new Set([
|
|
'id',
|
|
'email',
|
|
'first_name',
|
|
'last_name',
|
|
'auth_token',
|
|
'admin',
|
|
'group_permissions',
|
|
'app_group_permissions',
|
|
])
|
|
);
|
|
|
|
const { email, first_name, last_name, admin, group_permissions, app_group_permissions } = response.body;
|
|
|
|
expect(email).toEqual('ssoUser@tooljet.io');
|
|
expect(first_name).toEqual('Existing');
|
|
expect(last_name).toEqual('Name');
|
|
expect(admin).toBeTruthy();
|
|
expect(group_permissions).toHaveLength(2);
|
|
expect(group_permissions.map((p) => p.group).sort()).toEqual(['all_users', 'admin'].sort());
|
|
expect(Object.keys(group_permissions[0]).sort()).toEqual(
|
|
[
|
|
'id',
|
|
'organization_id',
|
|
'group',
|
|
'app_create',
|
|
'app_delete',
|
|
'folder_create',
|
|
'updated_at',
|
|
'created_at',
|
|
].sort()
|
|
);
|
|
expect(app_group_permissions).toHaveLength(0);
|
|
});
|
|
});
|
|
|
|
describe('sign in via Git OAuth', () => {
|
|
it('should return login info when the user does not exist', async () => {
|
|
const gitAuthResponse = jest.fn();
|
|
gitAuthResponse.mockImplementation(() => {
|
|
return {
|
|
json: () => {
|
|
return {
|
|
access_token: 'some-access-token',
|
|
scope: 'scope',
|
|
token_type: 'bearer',
|
|
};
|
|
},
|
|
};
|
|
});
|
|
const gitGetUserResponse = jest.fn();
|
|
gitGetUserResponse.mockImplementation(() => {
|
|
return {
|
|
json: () => {
|
|
return {
|
|
name: 'SSO UserGit',
|
|
email: 'ssoUserGit@tooljet.io',
|
|
};
|
|
},
|
|
};
|
|
});
|
|
|
|
mockedGot.mockImplementationOnce(gitAuthResponse);
|
|
mockedGot.mockImplementationOnce(gitGetUserResponse);
|
|
const token = 'some-token';
|
|
|
|
// Calling the createUser helper function to have an Organization created. This user is irrelevant for the test
|
|
await createUser(app, { email: 'anotherUser@tooljet.io', role: 'admin' });
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'git' });
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
expect(Object.keys(response.body).sort()).toEqual(
|
|
[
|
|
'id',
|
|
'email',
|
|
'first_name',
|
|
'last_name',
|
|
'auth_token',
|
|
'admin',
|
|
'group_permissions',
|
|
'app_group_permissions',
|
|
].sort()
|
|
);
|
|
|
|
const { email, first_name, last_name, admin, group_permissions, app_group_permissions } = response.body;
|
|
|
|
expect(email).toEqual('ssoUserGit@tooljet.io');
|
|
expect(first_name).toEqual('SSO');
|
|
expect(last_name).toEqual('UserGit');
|
|
expect(admin).toBeFalsy();
|
|
expect(group_permissions).toHaveLength(1);
|
|
expect(group_permissions[0].group).toEqual('all_users');
|
|
expect(Object.keys(group_permissions[0]).sort()).toEqual(
|
|
[
|
|
'id',
|
|
'organization_id',
|
|
'group',
|
|
'app_create',
|
|
'app_delete',
|
|
'updated_at',
|
|
'created_at',
|
|
'folder_create',
|
|
].sort()
|
|
);
|
|
expect(app_group_permissions).toHaveLength(0);
|
|
});
|
|
|
|
it('should be forbid logging in when the user does not exist and signups are disabled', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
if (key === 'SSO_DISABLE_SIGNUP') {
|
|
return 'true';
|
|
} else {
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const gitAuthResponse = jest.fn();
|
|
gitAuthResponse.mockImplementation(() => {
|
|
return {
|
|
json: () => {
|
|
return {
|
|
access_token: 'some-access-token',
|
|
scope: 'scope',
|
|
token_type: 'bearer',
|
|
};
|
|
},
|
|
};
|
|
});
|
|
const gitGetUserResponse = jest.fn();
|
|
gitGetUserResponse.mockImplementation(() => {
|
|
return {
|
|
json: () => {
|
|
return {
|
|
name: 'SSO UserGit',
|
|
email: 'ssoUserGit@tooljet.io',
|
|
};
|
|
},
|
|
};
|
|
});
|
|
|
|
mockedGot.mockImplementationOnce(gitAuthResponse);
|
|
mockedGot.mockImplementationOnce(gitGetUserResponse);
|
|
|
|
// Calling the createUser helper function to have an Organization created. This user is irrelevant for the test
|
|
await createUser(app, { email: 'anotherUser@tooljet.io', role: 'admin' });
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'git' });
|
|
|
|
expect(response.statusCode).toBe(401);
|
|
});
|
|
|
|
it('should return login info when the user exists', async () => {
|
|
const gitAuthResponse = jest.fn();
|
|
gitAuthResponse.mockImplementation(() => {
|
|
return {
|
|
json: () => {
|
|
return {
|
|
access_token: 'some-access-token',
|
|
scope: 'scope',
|
|
token_type: 'bearer',
|
|
};
|
|
},
|
|
};
|
|
});
|
|
const gitGetUserResponse = jest.fn();
|
|
gitGetUserResponse.mockImplementation(() => {
|
|
return {
|
|
json: () => {
|
|
return {
|
|
name: 'Existing Name',
|
|
email: 'ssoUserGit@tooljet.io',
|
|
};
|
|
},
|
|
};
|
|
});
|
|
|
|
mockedGot.mockImplementationOnce(gitAuthResponse);
|
|
mockedGot.mockImplementationOnce(gitGetUserResponse);
|
|
|
|
await createUser(app, {
|
|
email: 'ssoUserGit@tooljet.io',
|
|
role: 'developer',
|
|
ssoId: 'someSSOId',
|
|
firstName: 'Existing',
|
|
lastName: 'Name',
|
|
groups: ['all_users', 'admin'],
|
|
});
|
|
|
|
const token = 'someStuff';
|
|
|
|
const response = await request(app.getHttpServer()).post('/api/oauth/sign-in').send({ token, origin: 'git' });
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
expect(new Set(Object.keys(response.body))).toEqual(
|
|
new Set([
|
|
'id',
|
|
'email',
|
|
'first_name',
|
|
'last_name',
|
|
'auth_token',
|
|
'admin',
|
|
'group_permissions',
|
|
'app_group_permissions',
|
|
])
|
|
);
|
|
|
|
const { email, first_name, last_name, admin, group_permissions, app_group_permissions } = response.body;
|
|
|
|
expect(email).toEqual('ssoUserGit@tooljet.io');
|
|
expect(first_name).toEqual('Existing');
|
|
expect(last_name).toEqual('Name');
|
|
expect(admin).toBeTruthy();
|
|
expect(group_permissions).toHaveLength(2);
|
|
expect(group_permissions.map((p) => p.group).sort()).toEqual(['all_users', 'admin'].sort());
|
|
expect(Object.keys(group_permissions[0]).sort()).toEqual(
|
|
[
|
|
'id',
|
|
'organization_id',
|
|
'group',
|
|
'app_create',
|
|
'app_delete',
|
|
'folder_create',
|
|
'updated_at',
|
|
'created_at',
|
|
].sort()
|
|
);
|
|
expect(app_group_permissions).toHaveLength(0);
|
|
});
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await app.close();
|
|
});
|
|
});
|