mirror of
https://github.com/ToolJet/ToolJet
synced 2026-05-06 06:48:21 +00:00
* Fix: User group permissions error on Openshift platform (#4041) * update dockerfile for file permissions on root group * add permissions from the user group on dockerfile * bump to v1.24.4 * bump to v1.25.0 * [feature] Added pagination and filtering features to users page (#3921) * added pagination and filtering in backend * added pagination - created a seperate component for users table - added pagination * Added filter UI * temporary css fix for pagination footer * fixed pagination width issue * now result will also clear when user clicks on clear icon * Added seperate api for comment mentions * Now we can search mentions by email, first and last names * Fixed a bug - email didn't send for comment mentions * refactoring the code * resolved PR changes * Added isAdmin guard * adding some checks * fixed lint errors * added wild card search * Added no result found text * fixed failing test case * Working on PR changes * Now users table avatars will load image too * replaced skeleton classes with skeleton library component * Completed PR changes * added orderby * Fixed some issues * fixed failed test case * have fixed some css issues * replaced query with quersrting package * fixed minor width issue * Fixed some css issues * fixed darkMode issue * implemented on enter press search * Refactored the code * fixed white space issue * refactored the code * fixed overlapping issue * refactored the code * fixing some issues * fixes * removed guard * code cleanup * comments notification fix * fixed conflict issues * fixed css height issue Co-authored-by: gsmithun4 <gsmithun4@gmail.com> * Remove signup guard from set-password-from-token API (#4050) * Remove sign up guard set-password-from-token API * test cases fix * Bump to v1.25.1 * Feature: Add PG_DB_OWNER env var to disable db and extension creation (#4055) * add PG_DB_OWNER env var to disable db and extension creation * update docs * bump to v1.25.2 Co-authored-by: Akshay <akshaysasidharan93@gmail.com> Co-authored-by: Muhsin Shah C P <muhsinshah21@gmail.com>
487 lines
19 KiB
TypeScript
487 lines
19 KiB
TypeScript
import * as request from 'supertest';
|
|
import { INestApplication } from '@nestjs/common';
|
|
import { authHeaderForUser, clearDB, createUser, createNestAppInstanceWithEnvMock } from '../test.helper';
|
|
import { Repository } from 'typeorm';
|
|
import { SSOConfigs } from 'src/entities/sso_config.entity';
|
|
import { User } from 'src/entities/user.entity';
|
|
|
|
describe('organizations controller', () => {
|
|
let app: INestApplication;
|
|
let ssoConfigsRepository: Repository<SSOConfigs>;
|
|
let userRepository: Repository<User>;
|
|
let mockConfig;
|
|
|
|
beforeEach(async () => {
|
|
await clearDB();
|
|
});
|
|
|
|
beforeAll(async () => {
|
|
({ app, mockConfig } = await createNestAppInstanceWithEnvMock());
|
|
ssoConfigsRepository = app.get('SSOConfigsRepository');
|
|
userRepository = app.get('UserRepository');
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.resetAllMocks();
|
|
jest.clearAllMocks();
|
|
});
|
|
|
|
describe('list organization users', () => {
|
|
it('should allow only authenticated users to list org users', async () => {
|
|
await request(app.getHttpServer()).get('/api/organizations/users').expect(401);
|
|
});
|
|
|
|
it('should list organization users', async () => {
|
|
const userData = await createUser(app, { email: 'admin@tooljet.io' });
|
|
const { user, orgUser } = userData;
|
|
|
|
const response = await request(app.getHttpServer())
|
|
.get('/api/organizations/users?page=1')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
expect(response.body.users.length).toBe(1);
|
|
|
|
await orgUser.reload();
|
|
|
|
expect(response.body.users[0]).toStrictEqual({
|
|
email: user.email,
|
|
user_id: user.id,
|
|
first_name: user.firstName,
|
|
id: orgUser.id,
|
|
last_name: user.lastName,
|
|
name: `${user.firstName} ${user.lastName}`,
|
|
role: orgUser.role,
|
|
status: orgUser.status,
|
|
avatar_id: user.avatarId,
|
|
});
|
|
});
|
|
|
|
describe('create organization', () => {
|
|
it('should allow only authenticated users to create organization', async () => {
|
|
await request(app.getHttpServer()).post('/api/organizations').send({ name: 'My workspace' }).expect(401);
|
|
});
|
|
it('should create new organization if Multi-Workspace supported', async () => {
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.post('/api/organizations')
|
|
.send({ name: 'My workspace' })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
expect(response.body.organization_id).not.toBe(organization.id);
|
|
expect(response.body.organization).toBe('My workspace');
|
|
expect(response.body.admin).toBeTruthy();
|
|
|
|
const newUser = await userRepository.findOneOrFail({ where: { id: user.id } });
|
|
expect(newUser.defaultOrganizationId).toBe(response.body.organization_id);
|
|
});
|
|
|
|
it('should throw error if name is empty', async () => {
|
|
const { user } = await createUser(app, { email: 'admin@tooljet.io' });
|
|
const response = await request(app.getHttpServer())
|
|
.post('/api/organizations')
|
|
.send({ name: '' })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(400);
|
|
});
|
|
|
|
it('should not create new organization if Multi-Workspace not supported', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
switch (key) {
|
|
case 'DISABLE_MULTI_WORKSPACE':
|
|
return 'true';
|
|
default:
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const { user } = await createUser(app, { email: 'admin@tooljet.io' });
|
|
await request(app.getHttpServer())
|
|
.post('/api/organizations')
|
|
.send({ name: 'My workspace' })
|
|
.set('Authorization', authHeaderForUser(user))
|
|
.expect(403);
|
|
});
|
|
|
|
it('should create new organization if Multi-Workspace supported and user logged in via SSO', async () => {
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.post('/api/organizations')
|
|
.send({ name: 'My workspace' })
|
|
.set('Authorization', authHeaderForUser(user, null, false));
|
|
|
|
expect(response.statusCode).toBe(201);
|
|
expect(response.body.organization_id).not.toBe(organization.id);
|
|
expect(response.body.organization).toBe('My workspace');
|
|
expect(response.body.admin).toBeTruthy();
|
|
});
|
|
});
|
|
describe('update organization', () => {
|
|
it('should change organization params if changes are done by admin', async () => {
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations')
|
|
.send({ name: 'new name', domain: 'tooljet.io', enableSignUp: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
await organization.reload();
|
|
expect(organization.name).toBe('new name');
|
|
expect(organization.domain).toBe('tooljet.io');
|
|
expect(organization.enableSignUp).toBeTruthy();
|
|
});
|
|
|
|
it('should not change organization params if changes are not done by admin', async () => {
|
|
const { organization } = await createUser(app, { email: 'admin@tooljet.io' });
|
|
const developerUserData = await createUser(app, {
|
|
email: 'developer@tooljet.io',
|
|
groups: ['all_users'],
|
|
organization,
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations')
|
|
.send({ name: 'new name', domain: 'tooljet.io', enableSignUp: true })
|
|
.set('Authorization', authHeaderForUser(developerUserData.user));
|
|
|
|
expect(response.statusCode).toBe(403);
|
|
});
|
|
});
|
|
describe('update organization configs', () => {
|
|
it('should change organization configs if changes are done by admin', async () => {
|
|
const { user } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations/configs')
|
|
.send({ type: 'git', configs: { clientId: 'client-id', clientSecret: 'client-secret' }, enabled: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
const ssoConfigs = await ssoConfigsRepository.findOneOrFail({ where: { id: response.body.id } });
|
|
expect(ssoConfigs.sso).toBe('git');
|
|
expect(ssoConfigs.enabled).toBeTruthy();
|
|
expect(ssoConfigs.configs.clientId).toBe('client-id');
|
|
expect(ssoConfigs.configs['clientSecret']).not.toBe('client-secret');
|
|
});
|
|
|
|
it('should not change organization configs if changes are not done by admin', async () => {
|
|
const { user } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
groups: ['all_users'],
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations/configs')
|
|
.send({ type: 'git', configs: { clientId: 'client-id', clientSecret: 'client-secret' }, enabled: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(403);
|
|
});
|
|
});
|
|
describe('get organization configs', () => {
|
|
it('should get organization details if requested by admin', async () => {
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations/configs')
|
|
.send({ type: 'git', configs: { clientId: 'client-id', clientSecret: 'client-secret' }, enabled: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const getResponse = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
|
|
expect(getResponse.body.organization_details.id).toBe(organization.id);
|
|
expect(getResponse.body.organization_details.name).toBe(organization.name);
|
|
expect(getResponse.body.organization_details.sso_configs.length).toBe(2);
|
|
expect(getResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'form').organization_id).toBe(
|
|
organization.id
|
|
);
|
|
expect(getResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'git').enabled).toBeTruthy();
|
|
expect(getResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'git').configs).toEqual({
|
|
client_id: 'client-id',
|
|
client_secret: 'client-secret',
|
|
});
|
|
});
|
|
|
|
it('should not get organization configs if request not done by admin', async () => {
|
|
const { user } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
groups: ['all_users'],
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(403);
|
|
});
|
|
});
|
|
|
|
describe('get public organization configs', () => {
|
|
it('should get organization details for all users for single organization', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
switch (key) {
|
|
case 'DISABLE_MULTI_WORKSPACE':
|
|
return 'true';
|
|
default:
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const { user } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations/configs')
|
|
.send({ type: 'git', configs: { clientId: 'client-id', clientSecret: 'client-secret' }, enabled: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const authGetResponse = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(authGetResponse.statusCode).toBe(200);
|
|
|
|
const getResponse = await request(app.getHttpServer()).get('/api/organizations/public-configs');
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
expect(getResponse.body).toEqual({
|
|
sso_configs: {
|
|
name: 'Test Organization',
|
|
enable_sign_up: false,
|
|
form: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'form').id,
|
|
sso: 'form',
|
|
configs: {},
|
|
enabled: true,
|
|
},
|
|
git: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'git').id,
|
|
sso: 'git',
|
|
configs: { client_id: 'client-id', client_secret: '' },
|
|
enabled: true,
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it('should get organization details and should not consider instance level SSO for all users for single organization', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
switch (key) {
|
|
case 'DISABLE_MULTI_WORKSPACE':
|
|
return 'true';
|
|
case 'SSO_GOOGLE_OAUTH2_CLIENT_ID':
|
|
return 'google-client-id';
|
|
case 'SSO_GIT_OAUTH2_CLIENT_ID':
|
|
return 'git-client-id';
|
|
case 'SSO_GIT_OAUTH2_CLIENT_SECRET':
|
|
return 'git-secret';
|
|
default:
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const { user } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
|
|
const authGetResponse = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(authGetResponse.statusCode).toBe(200);
|
|
|
|
const getResponse = await request(app.getHttpServer()).get('/api/organizations/public-configs');
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
expect(getResponse.body).toEqual({
|
|
sso_configs: {
|
|
name: 'Test Organization',
|
|
enable_sign_up: false,
|
|
form: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'form').id,
|
|
sso: 'form',
|
|
configs: {},
|
|
enabled: true,
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it('should get organization specific details for all users for multiple organization deployment', async () => {
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations/configs')
|
|
.send({ type: 'git', configs: { clientId: 'client-id', clientSecret: 'client-secret' }, enabled: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const getResponse = await request(app.getHttpServer()).get(
|
|
`/api/organizations/${organization.id}/public-configs`
|
|
);
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
|
|
const authGetResponse = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(authGetResponse.statusCode).toBe(200);
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
expect(getResponse.body).toEqual({
|
|
sso_configs: {
|
|
name: 'Test Organization',
|
|
enable_sign_up: false,
|
|
form: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'form').id,
|
|
sso: 'form',
|
|
configs: {},
|
|
enabled: true,
|
|
},
|
|
git: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'git').id,
|
|
sso: 'git',
|
|
configs: { client_id: 'client-id', client_secret: '' },
|
|
enabled: true,
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it('should get organization specific details with instance level sso and override it with organization sso configs for all users for multiple organization deployment', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
switch (key) {
|
|
case 'SSO_GOOGLE_OAUTH2_CLIENT_ID':
|
|
return 'google-client-id';
|
|
case 'SSO_GIT_OAUTH2_CLIENT_ID':
|
|
return 'git-client-id';
|
|
case 'SSO_GIT_OAUTH2_CLIENT_SECRET':
|
|
return 'git-secret';
|
|
default:
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
|
|
const response = await request(app.getHttpServer())
|
|
.patch('/api/organizations/configs')
|
|
.send({ type: 'git', configs: { clientId: 'org-client-id', clientSecret: 'client-secret' }, enabled: true })
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(response.statusCode).toBe(200);
|
|
|
|
const getResponse = await request(app.getHttpServer()).get(
|
|
`/api/organizations/${organization.id}/public-configs`
|
|
);
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
|
|
const authGetResponse = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(authGetResponse.statusCode).toBe(200);
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
expect(getResponse.body).toEqual({
|
|
sso_configs: {
|
|
name: 'Test Organization',
|
|
enable_sign_up: false,
|
|
form: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'form').id,
|
|
sso: 'form',
|
|
configs: {},
|
|
enabled: true,
|
|
},
|
|
git: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'git').id,
|
|
sso: 'git',
|
|
configs: { client_id: 'org-client-id', client_secret: '' },
|
|
enabled: true,
|
|
},
|
|
google: {
|
|
sso: 'google',
|
|
configs: { client_id: 'google-client-id', client_secret: '' },
|
|
enabled: true,
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it('should get organization specific details with instance level sso for all users for multiple organization deployment', async () => {
|
|
jest.spyOn(mockConfig, 'get').mockImplementation((key: string) => {
|
|
switch (key) {
|
|
case 'SSO_GOOGLE_OAUTH2_CLIENT_ID':
|
|
return 'google-client-id';
|
|
case 'SSO_GIT_OAUTH2_CLIENT_ID':
|
|
return 'git-client-id';
|
|
case 'SSO_GIT_OAUTH2_CLIENT_SECRET':
|
|
return 'git-secret';
|
|
default:
|
|
return process.env[key];
|
|
}
|
|
});
|
|
const { user, organization } = await createUser(app, {
|
|
email: 'admin@tooljet.io',
|
|
});
|
|
|
|
const getResponse = await request(app.getHttpServer()).get(
|
|
`/api/organizations/${organization.id}/public-configs`
|
|
);
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
|
|
const authGetResponse = await request(app.getHttpServer())
|
|
.get('/api/organizations/configs')
|
|
.set('Authorization', authHeaderForUser(user));
|
|
|
|
expect(authGetResponse.statusCode).toBe(200);
|
|
|
|
expect(getResponse.statusCode).toBe(200);
|
|
expect(getResponse.body).toEqual({
|
|
sso_configs: {
|
|
name: 'Test Organization',
|
|
enable_sign_up: false,
|
|
form: {
|
|
config_id: authGetResponse.body.organization_details.sso_configs.find((ob) => ob.sso === 'form').id,
|
|
sso: 'form',
|
|
configs: {},
|
|
enabled: true,
|
|
},
|
|
git: {
|
|
sso: 'git',
|
|
configs: { client_id: 'git-client-id', client_secret: '' },
|
|
enabled: true,
|
|
},
|
|
google: {
|
|
sso: 'google',
|
|
configs: { client_id: 'google-client-id', client_secret: '' },
|
|
enabled: true,
|
|
},
|
|
},
|
|
});
|
|
});
|
|
});
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await app.close();
|
|
});
|
|
});
|