mirror of
https://github.com/ToolJet/ToolJet
synced 2026-05-24 09:28:31 +00:00
2 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Shantanu Mane
|
89448cf492
|
Feature: Group Admin (#16210)
* fix: add FK constraints, unique constraint, and down() to group_admins migration * fix: add explicit FK constraint names to group_admins migration * feat: add GroupAdmin TypeORM entity * fix: add Organization relation to GroupAdmin entity * feat: add group-admin FEATURE_KEY entries and feature configs * feat: add CE no-op stub for GroupAdminService * feat: register GroupAdminService/Controller in module; add group-admin controller (CE stub + EE impl) * feat: pass user to getAllGroup(); update interface and CE service signature * test: add e2e tests for group-admin assign, revoke, scoped access, and auto-revocation * fix: correct imports and tsconfig for group-admin e2e test - fix entity imports: use @entities alias instead of src/entities - fix module imports: use @modules alias instead of src/modules - remove unused findEntityOrFail import from test-helper - add jest to tsconfig types array for test type definitions - add test-helper path mapping to tsconfig for proper resolution * fix: register GroupAdmin entity in TypeOrmModule.forFeature for DI * fix: grant workspace admins all group-admin feature keys in ability factory * feat: add group-admin service methods Add getGroupAdmins, getAddableAdmins, assignGroupAdmin, revokeGroupAdmin methods to groupPermissionV2Service following existing fetch pattern. * feat: allow group-admin builders to access Groups link in workspace settings Add is_group_admin and canManageGroups to conditionObj (both useState initializer and subscribe handler). Change Groups link condition from ['admin'] to ['canManageGroups'] to allow admin OR group-admin builders. * feat: add Group Admins tab to group permission resources * fix: handle missing default groups for group-admin builders; hide admin-only controls * feat: make permissions and granular access tabs read-only for group-admin builders; hide role-change in users tab * feat: implement GroupAdminOrAdminRoute for session validation; enhance group admin management features * feat: add GET_USER_ADMIN_GROUPS feature and update related permissions; enhance user group management * feat: enhance group admin functionality; add builder role and improve admin assignment tests * Fix: Add compiler options to tsconfig.build.json * refactor: revert configs for test suite * feat: enhance group admin functionality with feature access checks and user removal permissions * feat: add option to duplicate group admins in duplicate group * feat: enhance group permissions management - Updated FeatureAbilityFactory to include additional checks for builder permissions and group-specific access. - Modified GroupPermissionsController to apply FeatureAbilityGuard for various endpoints, ensuring proper permission checks. - Enhanced GranularPermissionsController with appropriate guards for better access control. - Refactored GroupExistenceGuard to improve group validation logic and error handling. - Updated GroupPermissionsModule to streamline service and utility registrations. - Added unit tests for FeatureAbilityFactory and GroupExistenceGuard to ensure robust permission handling. * feat: implement afterUpdateUserRole method in RolesService * feat: refactor GroupPermissionsUtilService usage in GroupPermissionsModule * feat: enhance group permissions copyright and icons, minor bug fixes: * Bug fixes Co-authored-by: Copilot <copilot@github.com> * bugz Co-authored-by: Copilot <copilot@github.com> --------- Co-authored-by: Rudhra Deep Biswas <rudra21ultra@gmail.com> Co-authored-by: Copilot <copilot@github.com> |
||
|
Shantanu Mane
|
d91137edb3
|
feat: Workspace Env Config (#15593)
* feat: add environment configuration support for Git providers and enhance git sync functionality * feat: update Git environment constants and integrate OrganizationGitSyncRepository * feat: add testProviderConnection method to gitSyncService for testing Git provider connections * chore: remove scanning on module init * feat: integrate OrganizationEnvRegistryService and reload envConfig on workspace create and slug update * feat: eload env config on onboarding * feat: add testProviderConnection method and update LicenseBase for envGitMapping * fix: handle downgrade path for env registry * fix flaky case in granular access * uncommented changes * feat: update .gitignore to include additional environment files * feat: refactor organization environment handling and remove deprecated service * feat: implement Git environment registry service and refactor organization environment handling * feat: rename envGitMapping to workspaceEnv across licensing module * chore: remove unnecessary try-catch * refactor(org-env): update interfaces — remove callback contract, add ensureResolved Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: remove reload-on-org-event, swap bootstrap init order Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(org-env): add getResolvedOrganizationIds() to interface, CE stub, and test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: improve assertions in getResolvedOrganizationIds() test * feat: refactor GitEnvRegistryService import paths and add new service implementation * feat: add applyLicenseToResolvedOrgs method to IGitEnvRegistryService and GitEnvRegistryService * refactor: replace GitEnvRegistryService with GitSyncEnvUtilService and update related references * feat: add use_env_config column to organization_git_sync and remove env_git_provider column * refactor: remove EncryptionModule import and update OrganizationEnvModule imports * feat: introduce OrganizationEnvUtilService and update OrganizationEnvModule to utilize it --------- Co-authored-by: Yukti Goyal <yuktigoyal02@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> |