Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-04-21 21:47:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Updated data-cy with review comments

Browse source
This commit is contained in:
Srimanitejas123 2025-09-11 14:10:20 +05:30
parent 7e30956aa7
commit f7ea317b6f
3 changed files with 23 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress-tests/cypress/e2e/happyPath/workflows/eeTestcases/workflowfeatures.cy.js
View file

@ -75,7 +75,7 @@ describe("Workflows features", () => {
});
// Need to run after bug fixes
it.only("Creating workflow inside Workflow and validating execution", () => {
it("Creating workflow inside Workflow and validating execution", () => {
cy.createWorkflowApp(data.childWFName);
enterJsonInputInStartNode();
cy.connectDataSourceNode(workflowsText.runjsNodeLabel);

2
frontend/src/AppBuilder/QueryManager/QueryEditors/Workflows.jsx
View file

@ -52,6 +52,7 @@ export function Workflows({ options, optionsChanged, currentState }) {
return (
<>
<label className="mb-1">Workflow</label>
<div data-cy="workflow-dropdown"></div>
<Select
options={workflowOptions}
value={options.workflowId ?? {}}
@ -60,7 +61,6 @@ export function Workflows({ options, optionsChanged, currentState }) {
optionsChanged({ workflowId });
}}
placeholder="Select workflow"
data-cy="workflow-dropdown"
height="32px"
useMenuPortal={true}
closeMenuOnSelect={true}

44
frontend/src/_ui/Select/SelectComponent.jsx
View file

@ -57,28 +57,26 @@ export const SelectComponent = ({ options = [], value, onChange, closeMenuOnSele
};
return (
<div data-cy={restProps['data-cy']}>
<Select
{...restProps}
ref={selectRef}
selectRef={selectRef} // Exposed ref for custom components if needed
isLoading={isLoading}
isDisabled={isDisabled || isLoading}
options={selectOptions}
value={currentValue}
isSearchable={hasSearch}
onChange={handleOnChange}
placeholder={placeholder}
styles={customStyles}
openMenuOnFocus={openMenuOnFocus}
formatOptionLabel={(option) => renderCustomOption(option)}
menuPlacement={menuPlacement}
maxMenuHeight={maxMenuHeight}
menuPortalTarget={useMenuPortal ? document.body : menuPortalTarget}
closeMenuOnSelect={closeMenuOnSelect ?? true}
classNamePrefix={`${customClassPrefix} ${isDarkMode && 'dark-theme'} ${'react-select'}`}
data-cy={restProps['data-cy']}
/>
</div>
<Select
{...restProps}
ref={selectRef}
selectRef={selectRef}
isLoading={isLoading}
isDisabled={isDisabled || isLoading}
options={selectOptions}
value={currentValue}
isSearchable={hasSearch}
onChange={handleOnChange}
placeholder={placeholder}
styles={customStyles}
openMenuOnFocus={openMenuOnFocus}
formatOptionLabel={(option) => renderCustomOption(option)}
menuPlacement={menuPlacement}
maxMenuHeight={maxMenuHeight}
menuPortalTarget={useMenuPortal ? document.body : menuPortalTarget}
closeMenuOnSelect={closeMenuOnSelect ?? true}
classNamePrefix={`${customClassPrefix} ${isDarkMode && 'dark-theme'} ${'react-select'}`}
data-cy={restProps['data-cy']}
/>
);
};