Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-23 17:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

[Bug]: Fixed app crashes when items dropped into container inside listview (#5449)

Browse source 
* Fixed app crashes when items dropped into container inside listview

* Fixes Link widget crash
This commit is contained in:
Kavin Venkatachalam 2023-02-08 11:51:19 +05:30 committed by GitHub
parent 94f68039cb
commit f6e23fbd65
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
frontend/src/Editor/Box.jsx
View file

@ -1,4 +1,4 @@
import React, { useEffect, useState, useMemo, useContext } from 'react';
import React, { useEffect, useState, useMemo, useContext, useRef } from 'react';
import { Button } from './Components/Button';
import { Image } from './Components/Image';
import { Text } from './Components/Text';
@ -196,6 +196,8 @@ export const Box = function Box({
const { variablesExposedForPreview, exposeToCodeHinter } = useContext(EditorContext) || {};
const componentActions = useRef(new Set());
useEffect(() => {
const currentPage = currentState?.page;
@ -309,11 +311,16 @@ export const Box = function Box({
) {
if (!Object.keys(exposedVariables).includes(actionName)) {
func.dependencies = dependencies;
componentActions.current.add(actionName);
return onComponentOptionChanged(component, actionName, func);
} else if (exposedVariables[actionName]?.dependencies?.length === 0) {
return Promise.resolve();
} else if (!_.isEqual(dependencies, exposedVariables[actionName]?.dependencies)) {
} else if (
JSON.stringify(dependencies) !== JSON.stringify(exposedVariables[actionName]?.dependencies) ||
!componentActions.current.has(actionName)
) {
func.dependencies = dependencies;
componentActions.current.add(actionName);
return onComponentOptionChanged(component, actionName, func);
}
}

2
frontend/src/Editor/Components/Link.jsx
View file

@ -16,7 +16,7 @@ export const Link = ({ height, properties, styles, fireEvent, registerAction, da
async function () {
clickRef.current.click();
},
[clickRef]
[]
);
return (