Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-23 17:08:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

added function in group revamo

Browse source
This commit is contained in:
kriks7iitk 2024-05-02 10:38:07 +05:30
parent 461a05208a
commit ccaa17250d
1 changed files with 27 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
server/src/services/group_permissions.service.v2.ts
View file

@ -94,16 +94,28 @@ export class GroupPermissionsServiceV2 {
});
}
//Need more work
async updateGroup(id: string, updateGroupPermissionDto: UpdateGroupPermissionDto) {
const group = await this.getGroup(id);
const { editable, name } = group;
const { name: newName } = updateGroupPermissionDto;
if (newName && newName in USER_ROLE) {
throw new MethodNotAllowedException(ERROR_HANDLER.NON_EDITABLE_GROUP_UPDATE);
}
if (!editable) {
throw new MethodNotAllowedException(ERROR_HANDLER.NON_EDITABLE_GROUP_UPDATE);
}
if (name in [USER_ROLE.ADMIN, USER_ROLE.END_USER]) {
throw new MethodNotAllowedException(ERROR_HANDLER.NON_EDITABLE_GROUP_UPDATE);
}
return await dbTransactionWrap(async (manager: EntityManager) => {
const group = await this.getGroup(id, manager);
const { editable } = group;
//add complex logic for only builder
// this.validateUpdatePermissions(onlyBuilders,updateGroupPermissionDto);
if (!editable) throw new MethodNotAllowedException(ERROR_HANDLER.NON_EDITABLE_GROUP_UPDATE);
return await manager.delete(GroupPermissions, id);
if (!editable) return await manager.delete(GroupPermissions, id);
});
//Is editable only in paid plan builder group
}
@ -117,6 +129,16 @@ export class GroupPermissionsServiceV2 {
throw new BadRequestException(ERROR_HANDLER.NON_BUILDER_PERMISSION_UPDATE);
}
// async getUsersWithRole(role:USER_ROLE):Promise<GroupUsers[]>{
// const manager: EntityManager = getManager();
// return await manager
// .createQueryBuilder(GroupUsers, 'group_users')
// .innerJoinAndSelect('group_users.group', 'group')
// .where('group.type = :role', {
// versionId: appVersions.map((v) => v.id),
// })
// }
async getGroup(
id: string,
manager?: EntityManager,