From b75e2a4f3d558134dd20347a448cfb88d57a78da Mon Sep 17 00:00:00 2001 From: Nakul Nagargade Date: Mon, 7 Apr 2025 13:05:09 +0530 Subject: [PATCH 1/2] fix link QA bugs --- frontend/src/Editor/Components/Link/Link.jsx | 18 +++++++++++++----- frontend/src/Editor/Components/Link/link.scss | 18 ++++++++++++++---- 2 files changed, 27 insertions(+), 9 deletions(-) diff --git a/frontend/src/Editor/Components/Link/Link.jsx b/frontend/src/Editor/Components/Link/Link.jsx index 0b33686278..b15c582818 100644 --- a/frontend/src/Editor/Components/Link/Link.jsx +++ b/frontend/src/Editor/Components/Link/Link.jsx @@ -19,8 +19,7 @@ export const Link = ({ height, properties, styles, fireEvent, setExposedVariable const computedStyles = { display: 'flex', alignItems: verticalAlignment === 'top' ? 'flex-start' : verticalAlignment === 'center' ? 'center' : 'flex-end', - justifyContent: - horizontalAlignment === 'left' ? 'flex-start' : horizontalAlignment === 'center' ? 'center' : 'flex-end', + textAlign: horizontalAlignment === 'left' ? 'left' : horizontalAlignment === 'center' ? 'center' : 'right', height: '100%', width: '100%', boxShadow, @@ -113,10 +112,19 @@ export const Link = ({ height, properties, styles, fireEvent, setExposedVariable onMouseOver={() => { fireEvent('onHover'); }} - style={{ color: textColor, fontSize: textSize, cursor: isDisabled ? 'not-allowed' : 'pointer' }} + style={{ width: '100%' }} ref={clickRef} > - + {iconVisibility && ( )} - {linkTextState} + {linkTextState} diff --git a/frontend/src/Editor/Components/Link/link.scss b/frontend/src/Editor/Components/Link/link.scss index a92f19829f..20b375025f 100644 --- a/frontend/src/Editor/Components/Link/link.scss +++ b/frontend/src/Editor/Components/Link/link.scss @@ -1,8 +1,18 @@ .link-widget { a { - text-underline-offset: 32%; // Adds space between text and underline - &:hover { - color: var(--link-hover-color) !important; - } + text-decoration: none !important; + pointer-events: none; + cursor: none !important; + + .link-text { + pointer-events: all; + text-underline-offset: 32%; // Adds space between text and underline + cursor: pointer; + &:hover { + text-decoration: underline; + text-decoration-color: var(--link-hover-color) !important; + color: var(--link-hover-color) !important; + } } + } } From be01a024f253893cdbb44bed88b6103641ea028d Mon Sep 17 00:00:00 2001 From: Nakul Nagargade Date: Mon, 7 Apr 2025 13:11:44 +0530 Subject: [PATCH 2/2] fix --- frontend/src/Editor/Components/Link/Link.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/frontend/src/Editor/Components/Link/Link.jsx b/frontend/src/Editor/Components/Link/Link.jsx index b15c582818..3a5744df8e 100644 --- a/frontend/src/Editor/Components/Link/Link.jsx +++ b/frontend/src/Editor/Components/Link/Link.jsx @@ -123,6 +123,7 @@ export const Link = ({ height, properties, styles, fireEvent, setExposedVariable justifyContent: horizontalAlignment === 'left' ? 'flex-start' : horizontalAlignment === 'center' ? 'center' : 'flex-end', color: textColor, + paddingBottom: verticalAlignment === 'bottom' ? '1px' : '0px', }} > {iconVisibility && (