diff --git a/frontend/src/HomePage/FolderMenu.jsx b/frontend/src/HomePage/FolderMenu.jsx index d0949ecf1b..820652c11b 100644 --- a/frontend/src/HomePage/FolderMenu.jsx +++ b/frontend/src/HomePage/FolderMenu.jsx @@ -10,6 +10,7 @@ export const FolderMenu = function FolderMenu({ canDeleteFolder, canUpdateFolder, darkMode, + dataCy = '', }) { const [open, setOpen] = React.useState(false); const closeMenu = () => { @@ -28,7 +29,9 @@ export const FolderMenu = function FolderMenu({ closeMenu(); onClick(); }} - data-cy={`${text.toLowerCase().replace(/\s+/g, '-')}-card-option`} + data-cy={`${String(dataCy + '-' + text) + .toLowerCase() + .replace(/\s+/g, '-')}-option`} > {text} @@ -72,7 +75,7 @@ export const FolderMenu = function FolderMenu({ className={cx('folder-menu-icon', { 'd-grid': open, })} - data-cy="folder-card-menu-icon" + data-cy={`${dataCy.toLowerCase().replace(/\s+/g, '-')}-card-menu-icon`} > deleteFolder(folder)} editFolder={() => updateFolder(folder)} darkMode={darkMode} + dataCy={folder.name} /> )} diff --git a/frontend/src/ManageGroupPermissionResources/ManageGroupPermissionResources.jsx b/frontend/src/ManageGroupPermissionResources/ManageGroupPermissionResources.jsx index c625af0802..710308f9e7 100644 --- a/frontend/src/ManageGroupPermissionResources/ManageGroupPermissionResources.jsx +++ b/frontend/src/ManageGroupPermissionResources/ManageGroupPermissionResources.jsx @@ -333,7 +333,12 @@ class ManageGroupPermissionResourcesComponent extends React.Component { ) : (
-

{this?.props?.selectedGroup}

+

+ {this.props.selectedGroup} +

{(groupPermission.group == 'admin' || groupPermission.group == 'all_users') && (
@@ -346,7 +351,9 @@ class ManageGroupPermissionResourcesComponent extends React.Component {
this.props.updateGroupName(groupPermission)} - data-cy="update-link" + data-cy={`${String(groupPermission.group) + .toLowerCase() + .replace(/\s+/g, '-')}-group-name-update-link`} className="tj-text-xsm font-weight-500 edit-group" > @@ -355,7 +362,7 @@ class ManageGroupPermissionResourcesComponent extends React.Component { this.props.deleteGroup(groupPermission.id)} - data-cy="delete-link" + data-cy={`${String(groupPermission.group).toLowerCase().replace(/\s+/g, '-')}-group-delete-link`} > Delete group @@ -455,15 +462,19 @@ class ManageGroupPermissionResourcesComponent extends React.Component { {groupPermission.group == 'admin' && (
-

+

Admin has edit access to all apps. These are not editable

)}
-

App name

-

Permissions

+

+ App name +

+

+ Permissions +

{isLoadingGroup || isLoadingApps ? ( @@ -484,8 +495,14 @@ class ManageGroupPermissionResourcesComponent extends React.Component { <> {appsInGroup?.length > 0 ? ( appsInGroup.map((app) => ( - - + +
{app.name}
+ {app.name} +
@@ -511,8 +529,9 @@ class ManageGroupPermissionResourcesComponent extends React.Component { }} disabled={groupPermission.group === 'admin'} checked={this.canAppGroupPermission(app, groupPermission.id, 'edit')} + data-cy="checkbox-app-edit" /> - + {this.props.t('globals.edit', 'Edit')} @@ -541,12 +560,14 @@ class ManageGroupPermissionResourcesComponent extends React.Component { groupPermission.id, 'hideFromDashboard' )} + data-cy="checkbox-hide-from-dashboard" /> Hide from dashboard @@ -560,7 +581,6 @@ class ManageGroupPermissionResourcesComponent extends React.Component { onClick={() => { this.removeAppFromGroup(groupPermission.id, app.id, app.name); }} - data-cy="delete-link" className="delete-link" > Remove @@ -582,8 +603,13 @@ class ManageGroupPermissionResourcesComponent extends React.Component {
-

No apps are added to the group

- +

+ No apps are added to the group +

+ Add app to the group to control permissions
for users in this group
@@ -637,6 +663,9 @@ class ManageGroupPermissionResourcesComponent extends React.Component { iconWidth="16" className="add-users-button" isLoading={isAddingUsers} + data-cy={`${String(groupPermission.group) + .toLowerCase() + .replace(/\s+/g, '-')}-group-add-button`} > Add users @@ -652,7 +681,7 @@ class ManageGroupPermissionResourcesComponent extends React.Component {
{groupPermission.group == 'all_users' && ( -
+

All users include every users in the app. This list is not editable @@ -725,7 +754,7 @@ class ManageGroupPermissionResourcesComponent extends React.Component {

{groupPermission.group == 'admin' && (
-

+

Admin has all permissions

@@ -843,7 +872,9 @@ class ManageGroupPermissionResourcesComponent extends React.Component {
-
{this.props.t('globals.environmentVar', 'Environment variables')}
+
+ {this.props.t('globals.environmentVar', 'Environment variables')} +