From 957b1513af78dd4aa15a7c196b6ce2e7180ea8c9 Mon Sep 17 00:00:00 2001 From: Muhsin Shah C P Date: Wed, 18 Jun 2025 13:09:06 +0530 Subject: [PATCH] refactor: update signIn method signature in ISamlService interface (#13036) --- frontend/ee | 2 +- server/ee | 2 +- server/src/modules/auth/oauth/interfaces/ISamlService.ts | 6 +++++- server/src/modules/auth/oauth/util-services/saml.service.ts | 6 +++++- 4 files changed, 12 insertions(+), 4 deletions(-) diff --git a/frontend/ee b/frontend/ee index 30369d01c3..3dd7ce949b 160000 --- a/frontend/ee +++ b/frontend/ee @@ -1 +1 @@ -Subproject commit 30369d01c3b334b759531c5b83129465868a93e9 +Subproject commit 3dd7ce949b2abfe0aaf57b84b007083df0f4c1e1 diff --git a/server/ee b/server/ee index c494489625..11dac9bf1a 160000 --- a/server/ee +++ b/server/ee @@ -1 +1 @@ -Subproject commit c4944896259fd05a6b8d50368518d846c2e4d486 +Subproject commit 11dac9bf1ae3aed8629847da9cba8c9025e0c847 diff --git a/server/src/modules/auth/oauth/interfaces/ISamlService.ts b/server/src/modules/auth/oauth/interfaces/ISamlService.ts index 4a38906254..a83666f66b 100644 --- a/server/src/modules/auth/oauth/interfaces/ISamlService.ts +++ b/server/src/modules/auth/oauth/interfaces/ISamlService.ts @@ -1,7 +1,11 @@ import UserResponse from '../models/user_response'; export interface ISamlService { - signIn(samlResponseId: string, configs: any, configId: string): Promise; + signIn( + samlResponseId: string, + configs: any, + extraProps: { configId: string; orgSlug: string } + ): Promise; getSAMLAuthorizationURL(configId: string): Promise; getSAMLAssert(SAMLResponse: string): Promise; saveSAMLResponse(configId: string, response: string): Promise; diff --git a/server/src/modules/auth/oauth/util-services/saml.service.ts b/server/src/modules/auth/oauth/util-services/saml.service.ts index 4d345d6a3c..05bfb514bd 100644 --- a/server/src/modules/auth/oauth/util-services/saml.service.ts +++ b/server/src/modules/auth/oauth/util-services/saml.service.ts @@ -4,7 +4,11 @@ import UserResponse from '../models/user_response'; @Injectable() export class SamlService implements ISamlService { - async signIn(samlResponseId: string, configs: any, configId: string): Promise { + async signIn( + samlResponseId: string, + configs: any, + extraProps: { configId: string; orgSlug: string } + ): Promise { throw new Error('Method not implemented'); }