Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-05 22:38:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

fix: dont update state when appDef is equal to newDef (#2576)

Browse source
This commit is contained in:
Gandharv 2022-03-24 21:00:28 +05:00 committed by GitHub
parent 81bed483f9
commit 8a6df632d2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/src/Editor/Container.jsx
View file

@ -178,7 +178,7 @@ export const Container = ({
[left, top] = doSnapToGrid(canvasWidth, left, top);
}
left = (left * 100) / canvasWidth;
left = Math.round((left * 100) / canvasWidth);
if (item.currentLayout === 'mobile') {
componentData.definition.others.showOnDesktop.value = false;
@ -217,7 +217,7 @@ export const Container = ({
// Computing the left offset
const leftOffset = nodeBounds.x - canvasBounds.x;
const left = convertXToPercentage(leftOffset, canvasWidth);
const left = Math.round(convertXToPercentage(leftOffset, canvasWidth));
// Computing the top offset
const top = nodeBounds.y - canvasBounds.y;
@ -262,7 +262,7 @@ export const Container = ({
height = height + deltaHeight;
top = y;
left = (x * 100) / canvasWidth;
left = Math.round((x * 100) / canvasWidth);
let newBoxes = {
...boxes,

2
frontend/src/Editor/Editor.jsx
View file

@ -427,6 +427,8 @@ class Editor extends React.Component {
};
appDefinitionChanged = (newDefinition, opts = {}) => {
if (isEqual(this.state.appDefinition, newDefinition)) return;
produce(
this.state.appDefinition,
(draft) => {