From 39ad4167e4aa237a788de8688bc809171cd8ee92 Mon Sep 17 00:00:00 2001 From: Shaurya Sharma Date: Wed, 23 Oct 2024 16:08:39 +0530 Subject: [PATCH] Environment change dropdown missing value fix --- frontend/src/AppBuilder/Header/CreateVersionModal.jsx | 10 ++++++---- .../_stores/slices/environmentsAndVersionsSlice.js | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/frontend/src/AppBuilder/Header/CreateVersionModal.jsx b/frontend/src/AppBuilder/Header/CreateVersionModal.jsx index 6d9237f8e6..cb3fc653c2 100644 --- a/frontend/src/AppBuilder/Header/CreateVersionModal.jsx +++ b/frontend/src/AppBuilder/Header/CreateVersionModal.jsx @@ -26,6 +26,7 @@ export const CreateVersion = ({ showCreateAppVersion, setShowCreateAppVersion }) appId, setCurrentVersionId, selectedVersion, + fetchDevelopmentVersions, } = useStore( (state) => ({ createNewVersionAction: state.createNewVersionAction, @@ -40,14 +41,15 @@ export const CreateVersion = ({ showCreateAppVersion, setShowCreateAppVersion }) currentVersionId: state.currentVersionId, setCurrentVersionId: state.setCurrentVersionId, selectedVersion: state.selectedVersion, + fetchDevelopmentVersions: state.fetchDevelopmentVersions, }), shallow ); const [selectedVersionForCreation, setSelectedVersionForCreation] = useState(null); - // useEffect(() => { - // fetchDevelopmentVersions(appId); - // }, []); + useEffect(() => { + fetchDevelopmentVersions(appId); + }, []); useEffect(() => { if (developmentVersions?.length && selectedVersion?.id) { @@ -59,7 +61,7 @@ export const CreateVersion = ({ showCreateAppVersion, setShowCreateAppVersion }) const { t } = useTranslation(); console.log({ developmentVersions }); - const options = versionsPromotedToEnvironment.map((version) => { + const options = developmentVersions.map((version) => { return { label: version.name, value: version }; }); diff --git a/frontend/src/AppBuilder/_stores/slices/environmentsAndVersionsSlice.js b/frontend/src/AppBuilder/_stores/slices/environmentsAndVersionsSlice.js index a3d7384517..919e818bd9 100644 --- a/frontend/src/AppBuilder/_stores/slices/environmentsAndVersionsSlice.js +++ b/frontend/src/AppBuilder/_stores/slices/environmentsAndVersionsSlice.js @@ -54,7 +54,7 @@ export const createEnvironmentsAndVersionsSlice = (set, get) => ({ setEnvironmentDropdownStatus: (status) => set({ initializedEnvironmentDropdown: status }), fetchDevelopmentVersions: async (appId) => { - const developmentEnvironmentId = get().environments.find((environment) => environment.name === 'development').id; + const developmentEnvironmentId = get().environments.find((environment) => environment.name === 'production').id; try { const response = await appEnvironmentService.getVersionsByEnvironment(appId, developmentEnvironmentId);