Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-24 09:28:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #11087 from ToolJet/fix/environment-change-dropdown-issue

Browse source 
Environment change dropdown missing value fix
This commit is contained in:
Johnson Cherian 2024-10-24 11:24:57 +05:30 committed by GitHub
commit 8a4c921b10
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frontend/src/AppBuilder/Header/CreateVersionModal.jsx
View file

@ -26,6 +26,7 @@ export const CreateVersion = ({ showCreateAppVersion, setShowCreateAppVersion })
appId,
setCurrentVersionId,
selectedVersion,
fetchDevelopmentVersions,
} = useStore(
(state) => ({
createNewVersionAction: state.createNewVersionAction,
@ -40,14 +41,15 @@ export const CreateVersion = ({ showCreateAppVersion, setShowCreateAppVersion })
currentVersionId: state.currentVersionId,
setCurrentVersionId: state.setCurrentVersionId,
selectedVersion: state.selectedVersion,
fetchDevelopmentVersions: state.fetchDevelopmentVersions,
}),
shallow
);
const [selectedVersionForCreation, setSelectedVersionForCreation] = useState(null);
// useEffect(() => {
// fetchDevelopmentVersions(appId);
// }, []);
useEffect(() => {
fetchDevelopmentVersions(appId);
}, []);
useEffect(() => {
if (developmentVersions?.length && selectedVersion?.id) {
@ -59,7 +61,7 @@ export const CreateVersion = ({ showCreateAppVersion, setShowCreateAppVersion })
const { t } = useTranslation();
console.log({ developmentVersions });
const options = versionsPromotedToEnvironment.map((version) => {
const options = developmentVersions.map((version) => {
return { label: version.name, value: version };
});

2
frontend/src/AppBuilder/_stores/slices/environmentsAndVersionsSlice.js
View file

@ -54,7 +54,7 @@ export const createEnvironmentsAndVersionsSlice = (set, get) => ({
setEnvironmentDropdownStatus: (status) => set({ initializedEnvironmentDropdown: status }),
fetchDevelopmentVersions: async (appId) => {
const developmentEnvironmentId = get().environments.find((environment) => environment.name === 'development').id;
const developmentEnvironmentId = get().environments.find((environment) => environment.name === 'production').id;
try {
const response = await appEnvironmentService.getVersionsByEnvironment(appId, developmentEnvironmentId);