From 618e78834ebb63dc4692af5b2423f8ba681f626a Mon Sep 17 00:00:00 2001 From: johnsoncherian Date: Mon, 14 Apr 2025 18:14:42 +0530 Subject: [PATCH] fix: update version creatin and deletion error messages --- frontend/src/AppBuilder/Header/CreateVersionModal.jsx | 9 ++++++--- frontend/src/AppBuilder/Header/CustomSelect.jsx | 6 +----- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/frontend/src/AppBuilder/Header/CreateVersionModal.jsx b/frontend/src/AppBuilder/Header/CreateVersionModal.jsx index a4cb87ad55..3add0e6074 100644 --- a/frontend/src/AppBuilder/Header/CreateVersionModal.jsx +++ b/frontend/src/AppBuilder/Header/CreateVersionModal.jsx @@ -15,7 +15,7 @@ const CreateVersionModal = ({ canCommit, orgGit, fetchingOrgGit, - handleCommitOnVersionCreation = () => {}, + handleCommitOnVersionCreation = () => { }, }) => { const [isCreatingVersion, setIsCreatingVersion] = useState(false); const [versionName, setVersionName] = useState(''); @@ -94,12 +94,15 @@ const CreateVersionModal = ({ handleCommitOnVersionCreation(data); }) .catch((error) => { - console.log({ error }); toast.error(error); }); }, (error) => { - toast.error(error?.error); + if (error?.data?.code === "23505") { + toast.error("Version name already exists."); + } else { + toast.error(error?.error); + } setIsCreatingVersion(false); } ); diff --git a/frontend/src/AppBuilder/Header/CustomSelect.jsx b/frontend/src/AppBuilder/Header/CustomSelect.jsx index 863825fb31..0ea5199b36 100644 --- a/frontend/src/AppBuilder/Header/CustomSelect.jsx +++ b/frontend/src/AppBuilder/Header/CustomSelect.jsx @@ -150,11 +150,7 @@ export const CustomSelect = ({ currentEnvironment, onSelectVersion, ...props }) {/* When we merge this code to EE update the defaultAppEnvironments object with rest of default environments (then delete this comment)*/} 1 - ? 'Deleting a version will permanently remove it from all environments.' - : '' - }Are you sure you want to delete this version - ${decodeEntities(deleteVersion.versionName)}?`} + message={`Are you sure you want to delete this version - ${decodeEntities(deleteVersion.versionName)}?`} onConfirm={() => deleteAppVersion(deleteVersion.versionId, deleteVersion.versionName)} onCancel={resetDeleteModal} />