From 7a419796e3362bf66ce36b66a4ba0d8e7e675117 Mon Sep 17 00:00:00 2001
From: Kavin Venkatachalam
 <50441969+kavinvenkatachalam@users.noreply.github.com>
Date: Mon, 30 May 2022 14:06:10 +0530
Subject: [PATCH] PDF url null check added (#3142)

---
 frontend/src/Editor/Components/PDF.jsx | 71 +++++++++++++-------------
 1 file changed, 35 insertions(+), 36 deletions(-)

diff --git a/frontend/src/Editor/Components/PDF.jsx b/frontend/src/Editor/Components/PDF.jsx
index 442c4e7b75..de749705f4 100644
--- a/frontend/src/Editor/Components/PDF.jsx
+++ b/frontend/src/Editor/Components/PDF.jsx
@@ -46,46 +46,45 @@ export const PDF = React.memo(({ styles, properties, width, height }) => {
     [pageNumber]
   );
 
+  const renderPDF = () => (
+    <Document file={url} onLoadSuccess={onDocumentLoadSuccess} className="pdf-document">
+      {Array.from(new Array(numPages), (el, index) => (
+        <Page
+          pageNumber={index + 1}
+          width={scale ? width - 12 : undefined}
+          height={scale ? undefined : height}
+          key={`page_${index + 1}`}
+          inputRef={(el) => (pageRef.current[index] = el)}
+        />
+      ))}
+      {pageControls && (
+        <>
+          <div className="pdf-page-controls">
+            <button disabled={pageNumber <= 1} onClick={() => updatePage(-1)} type="button" aria-label="Previous page">
+              ‹
+            </button>
+            <span>
+              {pageNumber} of {numPages}
+            </span>
+            <button
+              disabled={pageNumber >= numPages}
+              onClick={() => updatePage(1)}
+              type="button"
+              aria-label="Next page"
+            >
+              ›
+            </button>
+          </div>
+        </>
+      )}
+    </Document>
+  );
+
   return (
     <div style={{ display: visibility ? 'flex' : 'none', width: width - 3, height }}>
       <div className="d-flex position-relative h-100" style={{ margin: '0 auto', overflow: 'hidden' }}>
         <div className="scrollable h-100 col position-relative" id="pdf-wrapper">
-          <Document file={url} onLoadSuccess={onDocumentLoadSuccess} className="pdf-document">
-            {Array.from(new Array(numPages), (el, index) => (
-              <Page
-                pageNumber={index + 1}
-                width={scale ? width - 12 : undefined}
-                height={scale ? undefined : height}
-                key={`page_${index + 1}`}
-                inputRef={(el) => (pageRef.current[index] = el)}
-              />
-            ))}
-            {pageControls && (
-              <>
-                <div className="pdf-page-controls">
-                  <button
-                    disabled={pageNumber <= 1}
-                    onClick={() => updatePage(-1)}
-                    type="button"
-                    aria-label="Previous page"
-                  >
-                    ‹
-                  </button>
-                  <span>
-                    {pageNumber} of {numPages}
-                  </span>
-                  <button
-                    disabled={pageNumber >= numPages}
-                    onClick={() => updatePage(1)}
-                    type="button"
-                    aria-label="Next page"
-                  >
-                    ›
-                  </button>
-                </div>
-              </>
-            )}
-          </Document>
+          {url === '' ? 'No PDF file specified' : renderPDF()}
         </div>
       </div>
     </div>