Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-24 09:28:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[appdef-2] fixes:Event handler are running twice for page load (#7705)

Browse source 
* fixes:Event handler are running twice for page load(eg- add 2 show alert and change the page).

* fixes: for viewer page events
This commit is contained in:
Arpit 2023-10-09 18:24:10 +05:30 committed by GitHub
parent f70fdb5a39
commit 6411a06e5d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
frontend/src/Editor/EditorFunc.jsx
View file

@ -687,9 +687,7 @@ const EditorComponent = (props) => {
await fetchDataQueries(data.editing_version?.id, true, true);
const currentPageEvents = data.events.filter((event) => event.target === 'page' && event.sourceId === homePageId);
for (const currentEvent of currentPageEvents ?? []) {
await handleEvent(currentEvent.name, currentPageEvents);
}
await handleEvent('onPageLoad', currentPageEvents);
};
//****** */
@ -1295,11 +1293,7 @@ const EditorComponent = (props) => {
const currentPageEvents = events.filter((event) => event.target === 'page' && event.sourceId === page.id);
(async () => {
for (const currentEvent of currentPageEvents ?? []) {
await handleEvent(currentEvent.name, currentPageEvents);
}
})();
handleEvent('onPageLoad', currentPageEvents);
};
const deletePageRequest = (pageId, isHomePage = false, pageName = '') => {

8
frontend/src/Editor/Viewer.jsx
View file

@ -217,9 +217,7 @@ class ViewerComponent extends React.Component {
(event) => event.target === 'page' && event.sourceId === this.state.currentPageId
);
for (const currentEvent of currentPageEvents ?? []) {
await this.handleEvent(currentEvent.name, currentPageEvents);
}
await this.handleEvent('onPageLoad', currentPageEvents);
});
}
);
@ -491,9 +489,7 @@ class ViewerComponent extends React.Component {
(event) => event.target === 'page' && event.sourceId === this.state.currentPageId
);
for (const currentEvent of currentPageEvents ?? []) {
await this.handleEvent(currentEvent.name, currentPageEvents);
}
await this.handleEvent('onPageLoad', currentPageEvents);
});
}
);