Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-22 08:28:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Fix for crash while adding more table columns

Browse source
This commit is contained in:
navaneeth 2021-05-05 07:07:56 +05:30
parent ea22e97152
commit 5a5be80703
2 changed files with 22 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
frontend/src/Editor/Inspector/Components/Table.jsx
View file

@ -213,7 +213,7 @@ class Table extends React.Component {
/>
<EventSelector
param="onClick"
eventMeta={{ displayName: 'On click'}}
eventMeta={{ displayName: 'On click' }}
definition={action.onClick}
eventUpdated={this.actionButtonEventUpdated}
dataQueries={this.state.dataQueries}
@ -248,10 +248,26 @@ class Table extends React.Component {
this.props.paramUpdated({ name: 'columns' }, 'value', newColumns, 'properties');
};
generateNewColumnName = (columns) => {
let found = false;
let columnName = '';
let currentNumber = 1;
while (!found) {
columnName = `new_column${currentNumber}`;
if (columns.find(column => column.name === columnName) === undefined) {
found = true;
}
currentNumber += 1;
}
return columnName;
}
addNewColumn = () => {
const columns = this.state.component.component.definition.properties.columns;
const newValue = columns.value;
newValue.push({ name: 'new_column' });
newValue.push({ name: this.generateNewColumnName(columns.value) });
this.props.paramUpdated({ name: 'columns' }, 'value', newValue, 'properties');
};
@ -362,11 +378,11 @@ class Table extends React.Component {
<hr></hr>
{renderElement(component, componentMeta, paramUpdated, dataQueries, 'serverSidePagination', 'properties', currentState)}
<hr></hr>
{renderEvent(component, eventUpdated, dataQueries, eventOptionUpdated, 'onRowClicked', componentMeta.events['onRowClicked'])}
{renderEvent(component, eventUpdated, dataQueries, eventOptionUpdated, 'onPageChanged', componentMeta.events['onPageChanged'])}
{renderEvent(component, eventUpdated, dataQueries, eventOptionUpdated, 'onRowClicked', componentMeta.events.onRowClicked)}
{renderEvent(component, eventUpdated, dataQueries, eventOptionUpdated, 'onPageChanged', componentMeta.events.onPageChanged)}
<div className="field mb-2 mt-2">
<label className="form-label mt-2">Bulk update query</label>

1
frontend/src/_helpers/utils.js
View file

@ -100,6 +100,7 @@ export function computeComponentName(componentType, currentComponents) {
if (Object.values(currentComponents).find(component => component.name === componentName) === undefined) {
found = true;
}
currentNumber = currentNumber + 1;
}
return componentName;