Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-24 01:18:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

[appdef-2] subcontainer dnd height outbound fix (#7767)

Browse source 
* fixes: listview children can be dragged outside its outbound limit

* cleanup
This commit is contained in:
Arpit 2023-10-11 13:41:10 +05:30 committed by GitHub
parent 61df66b108
commit 520f8fcfe8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frontend/src/Editor/SubContainer.jsx
View file

@ -295,6 +295,7 @@ export const SubContainer = ({
}
});
//!Todo: need to check: this never gets called as draggingState is always false
useEffect(() => {
setIsDragging(draggingState);
}, [draggingState]);
@ -383,6 +384,7 @@ export const SubContainer = ({
enableReleasedVersionPopupState();
return;
}
console.log('---arpit---onDragStop---');
const canvasWidth = getContainerCanvasWidth();
const nodeBounds = direction.node.getBoundingClientRect();
@ -610,6 +612,7 @@ export const SubContainer = ({
onComponentHover={onComponentHover}
hoveredComponent={hoveredComponent}
parentId={parentComponent?.name}
parent={parent}
sideBarDebugger={sideBarDebugger}
exposedVariables={exposedVariables ?? {}}
childComponents={childComponents[key]}