From 445a03f51c12b515079f97d9b28bd1eebfa68be8 Mon Sep 17 00:00:00 2001 From: devanshu052000 Date: Thu, 24 Apr 2025 16:42:35 +0530 Subject: [PATCH] Fix: Include admins and builders for setting page permissions and it applies to all on released apps --- server/ee | 2 +- server/src/modules/app-permissions/constants/index.ts | 1 + server/src/modules/app-permissions/interfaces/IUtilService.ts | 2 +- server/src/modules/app-permissions/util.service.ts | 2 +- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/server/ee b/server/ee index 78c6a52262..90e11056eb 160000 --- a/server/ee +++ b/server/ee @@ -1 +1 @@ -Subproject commit 78c6a52262ba2df4a0771ae778178d2d74bb7517 +Subproject commit 90e11056ebdb40f0560ece55198c3ecc8ead4988 diff --git a/server/src/modules/app-permissions/constants/index.ts b/server/src/modules/app-permissions/constants/index.ts index ef0b13f325..c1d2afe78b 100644 --- a/server/src/modules/app-permissions/constants/index.ts +++ b/server/src/modules/app-permissions/constants/index.ts @@ -1,6 +1,7 @@ export enum PAGE_PERMISSION_TYPE { SINGLE = 'SINGLE', GROUP = 'GROUP', + ALL = 'ALL', } export enum FEATURE_KEY { diff --git a/server/src/modules/app-permissions/interfaces/IUtilService.ts b/server/src/modules/app-permissions/interfaces/IUtilService.ts index 0d2be25315..06654ed9e9 100644 --- a/server/src/modules/app-permissions/interfaces/IUtilService.ts +++ b/server/src/modules/app-permissions/interfaces/IUtilService.ts @@ -3,7 +3,7 @@ import { GroupPermissions } from '@entities/group_permissions.entity'; import { CreatePagePermissionDto } from '../dto'; export interface IUtilService { - getUsersWithViewAccess(appId: string, organizationId: string, endUserIds: string[]): Promise; + getUsersWithViewAccess(appId: string, organizationId: string): Promise; getUserGroupsWithViewAccess(appId: string, organizationId: string): Promise; diff --git a/server/src/modules/app-permissions/util.service.ts b/server/src/modules/app-permissions/util.service.ts index 377c693a26..71432a0e4b 100644 --- a/server/src/modules/app-permissions/util.service.ts +++ b/server/src/modules/app-permissions/util.service.ts @@ -12,7 +12,7 @@ export class AppPermissionsUtilService implements IUtilService { throw new Error('Method not implemented.'); } - async getUsersWithViewAccess(appId: string, organizationId: string, endUserIds: string[]): Promise { + async getUsersWithViewAccess(appId: string, organizationId: string): Promise { throw new Error('Method not implemented.'); }