diff --git a/frontend/src/Editor/Editor.jsx b/frontend/src/Editor/Editor.jsx index d0b8d65bcb..c0d00ddc65 100644 --- a/frontend/src/Editor/Editor.jsx +++ b/frontend/src/Editor/Editor.jsx @@ -545,7 +545,7 @@ class Editor extends React.Component {
this.setState({ showDataSourceManagerModal: true, selectedDataSource: null })} > @@ -641,7 +641,7 @@ class Editor extends React.Component { this.setState({ selectedQuery: {}, editingQuery: false, addingQuery: true })} > + diff --git a/frontend/src/Editor/Inspector/Elements/Code.jsx b/frontend/src/Editor/Inspector/Elements/Code.jsx index 68d94173e1..2513b417c7 100644 --- a/frontend/src/Editor/Inspector/Elements/Code.jsx +++ b/frontend/src/Editor/Inspector/Elements/Code.jsx @@ -1,6 +1,6 @@ import React from 'react'; import { CodeHinter } from '../../CodeBuilder/CodeHinter'; -import { getToolTipProps } from './utils'; +import { ToolTip } from './Components/ToolTip'; export const Code = ({ param, definition, onChange, paramType, dataQueries, components, componentMeta, currentState @@ -17,7 +17,7 @@ export const Code = ({ return (
- + - + {showPicker && (
diff --git a/frontend/src/Editor/Inspector/Elements/Components/ToolTip.jsx b/frontend/src/Editor/Inspector/Elements/Components/ToolTip.jsx new file mode 100644 index 0000000000..3bbefe71ee --- /dev/null +++ b/frontend/src/Editor/Inspector/Elements/Components/ToolTip.jsx @@ -0,0 +1,37 @@ +import React from 'react'; +import OverlayTrigger from 'react-bootstrap/OverlayTrigger'; +import Tooltip from 'react-bootstrap/Tooltip'; + +const tooltipStyle = { + textDecorationLine: 'underline', + textDecorationStyle: 'dashed' +} + +export const ToolTip = ({ + label, meta, labelClass +}) => { + + function renderTooltip(props) { + return + {meta.tip} + + }; + + if (meta.tip) { + return ( + + + ); + } else { + return (); + } +} diff --git a/frontend/src/Editor/Inspector/Elements/Json.jsx b/frontend/src/Editor/Inspector/Elements/Json.jsx index aa059d35f3..3aac922237 100644 --- a/frontend/src/Editor/Inspector/Elements/Json.jsx +++ b/frontend/src/Editor/Inspector/Elements/Json.jsx @@ -1,7 +1,7 @@ import React from 'react'; import CodeMirror from '@uiw/react-codemirror'; import 'codemirror/theme/duotone-light.css'; -import { getToolTipProps } from './utils'; +import { ToolTip } from './Components/ToolTip'; export const Json = ({ param, definition, onChange, paramType, componentMeta @@ -19,7 +19,7 @@ export const Json = ({ return (
- + - + - + onChange(param, 'value', e.target.value, paramType)} diff --git a/frontend/src/Editor/Inspector/Elements/Toggle.jsx b/frontend/src/Editor/Inspector/Elements/Toggle.jsx index 66a31b1db7..03ca68d021 100644 --- a/frontend/src/Editor/Inspector/Elements/Toggle.jsx +++ b/frontend/src/Editor/Inspector/Elements/Toggle.jsx @@ -1,5 +1,5 @@ import React from 'react'; -import { getToolTipProps } from './utils'; +import { ToolTip } from './Components/ToolTip'; export const Toggle = ({ param, definition, onChange, paramType, componentMeta @@ -17,9 +17,7 @@ export const Toggle = ({ onClick={() => onChange(param, 'value', !value, paramType)} checked={value} /> - - {displayName} - +
); diff --git a/frontend/src/Editor/Inspector/Elements/utils.js b/frontend/src/Editor/Inspector/Elements/utils.js index d3bcbc9350..e69de29bb2 100644 --- a/frontend/src/Editor/Inspector/Elements/utils.js +++ b/frontend/src/Editor/Inspector/Elements/utils.js @@ -1,14 +0,0 @@ - -export function getToolTipProps(paramMeta) { - if(paramMeta.tip) { - return { - style: { - textDecorationLine: 'underline', - textDecorationStyle: 'dashed' - }, - ['data-tip']: paramMeta.tip - } - } else { - return {} - } -} diff --git a/frontend/src/Editor/Inspector/Inspector.jsx b/frontend/src/Editor/Inspector/Inspector.jsx index 8c733e61b1..0a9ea28788 100644 --- a/frontend/src/Editor/Inspector/Inspector.jsx +++ b/frontend/src/Editor/Inspector/Inspector.jsx @@ -89,7 +89,6 @@ export const Inspector = ({ return (
-
@@ -164,10 +163,10 @@ export const Inspector = ({ {!['Table', 'Chart'].includes(componentMeta.component) &&
{Object.keys(componentMeta.properties).map((property) => renderElement(component, componentMeta, paramUpdated, dataQueries, property, 'properties', currentState, components))} -
Events
- {Object.keys(componentMeta.events).map((eventName) => renderEvent(component, eventUpdated, dataQueries, eventOptionUpdated, eventName, componentMeta.events[eventName], currentState, components))}
Style
{Object.keys(componentMeta.styles).map((style) => renderElement(component, componentMeta, paramUpdated, dataQueries, style, 'styles', currentState, components))} +
Events
+ {Object.keys(componentMeta.events).map((eventName) => renderEvent(component, eventUpdated, dataQueries, eventOptionUpdated, eventName, componentMeta.events[eventName], currentState, components))}
}