Elgato_dark/ToolJet
1
0
Fork 0
mirror of https://github.com/ToolJet/ToolJet synced 2026-05-24 09:28:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix: replaced this by page name (#6069)

Browse source 
* Fix: replaced this by page name

* Fix: replaced current page reference
This commit is contained in:
Aditya Pratap Singh Hada 2023-04-29 20:08:19 +05:30 committed by GitHub
parent 328df6c85b
commit 2638b0285a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/src/Editor/Editor.jsx
View file

@ -1403,12 +1403,13 @@ class EditorComponent extends React.Component {
); );
}; };
deletePageRequest = (pageId, isHomePage = false) => { deletePageRequest = (pageId, isHomePage = false, pageName = '') => {
this.setState({ this.setState({
showPageDeletionConfirmation: { showPageDeletionConfirmation: {
isOpen: true, isOpen: true,
pageId, pageId,
isHomePage, isHomePage,
pageName,
}, },
}); });
}; };
@ -1419,6 +1420,7 @@ class EditorComponent extends React.Component {
isOpen: false, isOpen: false,
pageId: null, pageId: null,
isHomePage: false, isHomePage: false,
pageName: null,
}, },
}); });
}; };
@ -1837,7 +1839,7 @@ class EditorComponent extends React.Component {
<Confirm <Confirm
show={this.state.showPageDeletionConfirmation?.isOpen ?? false} show={this.state.showPageDeletionConfirmation?.isOpen ?? false}
title={'Delete Page'} title={'Delete Page'}
message={`Do you really want to delete this page?`} message={`Do you really want to delete ${this.state.showPageDeletionConfirmation?.pageName || 'this'} page?`}
confirmButtonLoading={this.state.isDeletingPage} confirmButtonLoading={this.state.isDeletingPage}
onConfirm={() => this.executeDeletepageRequest()} onConfirm={() => this.executeDeletepageRequest()}
onCancel={() => this.cancelDeletePageRequest()} onCancel={() => this.cancelDeletePageRequest()}

2
frontend/src/Editor/LeftSidebar/SidebarPageSelector/PageHandler.jsx
View file

@ -54,7 +54,7 @@ export const PageHandler = ({
setIsHovered(false); setIsHovered(false);
switch (id) { switch (id) {
case 'delete-page': case 'delete-page':
deletePage(page.id, isHomePage); deletePage(page.id, isHomePage, page.name);
break; break;
case 'rename-page': case 'rename-page':